From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH RFC] fs: introduce a default_open for simple f_op->open
 use
Date: Mon, 06 Jun 2011 13:36:10 +0300
Message-ID: <1307356570.3112.31.camel@localhost>
References: <201106021504.55799.hartleys@visionengravers.com>
Reply-To: dedekind1@gmail.com
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	matthew@wil.cx, dwmw2@infradead.org, robert.richter@amd.com,
	gregkh@suse.de, jmorris@namei.org, npiggin@kernel.dk,
	ak@linux.intel.com, dchinner@redhat.com
To: H Hartley Sweeten <hartleys@visionengravers.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:35210 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752500Ab1FFKk2 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 6 Jun 2011 06:40:28 -0400
In-Reply-To: <201106021504.55799.hartleys@visionengravers.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2011-06-02 at 15:04 -0700, H Hartley Sweeten wrote:
> There are many f_op->open implementations that simply do:
>=20
> 	file->private_data =3D inode->i_private;
>=20
> This introduces a new global symbol, default_open, that can be
> used instead of the private implementations.
>=20
> This also removes a couple private implementations that share the
> same symbol name.
>=20
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Matthew Wilcox <matthew@wil.cx>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Robert Richter <robert.richter@amd.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: James Morris <jmorris@namei.org>
> Cc: Nick Piggin <npiggin@kernel.dk>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Dave Chinner <dchinner@redhat.com>
>=20
> ---
>=20
> If this patch looks reasonable, I have some additional patches that
> convert all other similar f_op->open implemenations to use default_op=
en
> tree wide.  The full diffstat looks like this:

Looks good to me, thanks.

--=20
Best Regards,
Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E=
=D1=86=D0=BA=D0=B8=D0=B9)

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html