linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vasily Novikov <vasily.novikov-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org>
Cc: "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"malware-list-h+Im9A44IAFcMpApZELgcQ@public.gmane.org"
	<malware-list-h+Im9A44IAFcMpApZELgcQ@public.gmane.org>,
	Douglas Leeder
	<douglas.leeder-j34lQMj1tz/QT0dZR+AlfA@public.gmane.org>
Subject: Re: A few concerns about fanotify implementation.
Date: Mon, 06 Jun 2011 11:53:11 -0400	[thread overview]
Message-ID: <1307375593.2052.7.camel@localhost.localdomain> (raw)
In-Reply-To: <4DECE76E.4060507-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org>

On Mon, 2011-06-06 at 18:42 +0400, Vasily Novikov wrote:
> On 06/06/2011 05:43 PM, Eric Paris wrote:
> > Well, you are both correct.  If you add a mark with only 'ignored'
> > events set it will not pin the inode into the kernel.  If the system
> > starts to get under memory pressure the kernel will kick unused inodes
> > and any associated ignored marks out of ram.  Inodes with 'real' events
> > attached will be pinned in memory and cannot be evicted under memory
> > pressure.
> 
> So if we use marks with only 'ignored' events then under memory pressure 
> mm subsystem will shrink inode cache that will free our marks and 
> therefore it's safe to use FAN_UNLIMITED_MARKS in this case?
> If it really works then we don't need LRU cache in fanotify because it's 
> already implemented in dentry_cache/inode_cache.

That's how it's supposed to work.  Just remember, if you set a real
event, the inode becomes pinned in core and the mm will be unable to
evict either the inode or the mark.

-Eric

  parent reply	other threads:[~2011-06-06 15:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 12:13 A few concerns about fanotify implementation Vasily Novikov
2010-10-26 12:58 ` [malware-list] " Tvrtko Ursulin
2010-10-26 13:58   ` Vasily Novikov
2010-10-26 14:22     ` Tvrtko Ursulin
     [not found]       ` <201010261522.34157.tvrtko.ursulin-j34lQMj1tz/QT0dZR+AlfA@public.gmane.org>
2010-10-26 14:58         ` Eric Paris
2010-10-27  8:54   ` [malware-list] " Vasily Novikov
2010-10-27 15:58     ` Eric Paris
     [not found]       ` <1288195134.2655.202.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2011-06-03  9:43         ` Vasily Novikov
     [not found]           ` <4DE8ACAD.2080003-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org>
2011-06-06  9:02             ` Douglas Leeder
2011-06-06  9:19               ` [malware-list] " Vasily Novikov
     [not found]                 ` <4DEC9B86.6060506-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org>
2011-06-06 13:43                   ` Eric Paris
2011-06-06 14:42                     ` [malware-list] " Vasily Novikov
     [not found]                       ` <4DECE76E.4060507-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org>
2011-06-06 15:53                         ` Eric Paris [this message]
2011-06-07 12:35                           ` Vasily Novikov
     [not found]               ` <C511438CDC161C41B3C47B91D99ABA8D37B4B42114-u5UUZ0l8pcxUerCGrXd8jcc3qqyFMPEu@public.gmane.org>
2011-06-06  9:42                 ` Vasily Novikov
2011-06-06 10:27           ` [malware-list] " Lino Sanfilippo
2011-06-06 11:17             ` [malware-list] A few concerns about fanotify implementation ([PATCH] inside) Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307375593.2052.7.camel@localhost.localdomain \
    --to=eparis-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=douglas.leeder-j34lQMj1tz/QT0dZR+AlfA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=malware-list-h+Im9A44IAFcMpApZELgcQ@public.gmane.org \
    --cc=vasily.novikov-BkmlMuIjteXqlBn2x/YWAg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).