From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Mel Gorman <mgorman@suse.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: mmotm 2011-06-15-16-56 uploaded (mm/page_cgroup.c)
Date: Thu, 16 Jun 2011 11:46:04 -0700 [thread overview]
Message-ID: <1308249964.11430.157.camel@nimitz> (raw)
In-Reply-To: <20110616165146.GB5244@suse.de>
On Thu, 2011-06-16 at 17:51 +0100, Mel Gorman wrote:
> No, why was node_start_pfn() and node_end_pfn() defined optionally
> on a per-architecture basis?
Probably because it started in the NUMA-Q port, and we were still trying
to stay off the radar at that point. It looks like it showed up in
~2.5.[3-4]?. We didn't know what the heck we were doing back then, and
it probably leaked out from under CONFIG_NUMA/DISCONTIGMEM at some
point.
Seems like a good thing to consolidate to me. Especially since it's
just a shortcut to the (unconditionally defined) structure member, I
can't see a real justification for needing different definitions.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-16 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 23:56 mmotm 2011-06-15-16-56 uploaded akpm
2011-06-16 1:29 ` mmotm 2011-06-15-16-56 uploaded (UML build error) Randy Dunlap
2011-06-16 4:44 ` mmotm 2011-06-15-16-56 uploaded (mm/migrate) Randy Dunlap
2011-06-16 4:49 ` mmotm 2011-06-15-16-56 uploaded (mm/page_cgroup.c) Randy Dunlap
2011-06-16 5:48 ` KAMEZAWA Hiroyuki
2011-06-16 8:28 ` KAMEZAWA Hiroyuki
2011-06-16 10:35 ` Mel Gorman
2011-06-16 16:25 ` Dave Hansen
2011-06-16 16:51 ` Mel Gorman
2011-06-16 18:46 ` Dave Hansen [this message]
2011-06-17 7:55 ` Mel Gorman
2011-06-17 0:46 ` [BUGFIX][PATCH][-rc3] Define a consolidated definition of node_start/end_pfn for build error in page_cgroup.c (Was " KAMEZAWA Hiroyuki
2011-06-17 7:57 ` Mel Gorman
2011-06-17 16:58 ` Randy Dunlap
2011-06-20 16:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308249964.11430.157.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).