* [PATCH][Resend] Fix infinite loop in search_binary_handler()
@ 2011-06-27 21:17 Richard Weinberger
0 siblings, 0 replies; only message in thread
From: Richard Weinberger @ 2011-06-27 21:17 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Richard Weinberger
When search_binary_handler() is called to find a handler
for /sbin/modprobe it will end up in an infinite loop because
it executes request_module() to load a binfmt module with
/sbin/modprobe...
Running a x86_64 kernel without ia32 emulation and a x86 user land
triggers this issue.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
fs/exec.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 97e0d52..7271b22 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1411,7 +1411,10 @@ int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs)
printable(bprm->buf[2]) &&
printable(bprm->buf[3]))
break; /* -ENOEXEC */
- request_module("binfmt-%04x", *(unsigned short *)(&bprm->buf[2]));
+
+ /* Avoid an infinite loop */
+ if (strcmp(modprobe_path, bprm->filename))
+ request_module("binfmt-%04x", *(unsigned short *)(&bprm->buf[2]));
#endif
}
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-27 21:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-27 21:17 [PATCH][Resend] Fix infinite loop in search_binary_handler() Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).