From: Steven Whitehouse <swhiteho@redhat.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@ZenIV.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
Date: Mon, 04 Jul 2011 09:54:44 +0100 [thread overview]
Message-ID: <1309769684.2704.0.camel@menhir> (raw)
In-Reply-To: <1309275310-10987-1-git-send-email-josef@redhat.com>
Hi,
On Tue, 2011-06-28 at 11:35 -0400, Josef Bacik wrote:
> Btrfs needs to be able to control how filemap_write_and_wait_range() is called
> in fsync to make it less of a painful operation, so push down taking i_mutex and
> the calling of filemap_write_and_wait() down into the ->fsync() handlers. Some
> file systems can drop taking the i_mutex altogether it seems, like ext3 and
> ocfs2. For correctness sake I just pushed everything down in all cases to make
> sure that we keep the current behavior the same for everybody, and then each
> individual fs maintainer can make up their mind about what to do from there.
> Thanks,
>
> Signed-off-by: Josef Bacik <josef@redhat.com>
The GFS2 bit looks ok to me...
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
next prev parent reply other threads:[~2011-07-04 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 15:35 [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Josef Bacik
2011-06-29 16:38 ` Jan Kara
2011-06-29 17:41 ` Josef Bacik
2011-06-29 17:05 ` richard -rw- weinberger
2011-07-04 8:54 ` Steven Whitehouse [this message]
2011-07-19 10:24 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-06-29 18:05 Josef Bacik
2011-06-29 18:09 ` Christoph Hellwig
2011-06-29 18:14 ` Josef Bacik
2011-06-29 19:26 ` Jan Kara
2011-07-23 18:09 ` Markus Trippelsdorf
2011-07-23 19:32 ` Markus Trippelsdorf
2011-07-23 20:26 ` Josef Bacik
2011-07-23 20:38 ` Markus Trippelsdorf
2011-07-23 22:02 ` Markus Trippelsdorf
2011-07-24 11:16 ` Christoph Hellwig
2011-07-24 11:42 ` Christoph Hellwig
2011-07-25 17:38 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309769684.2704.0.camel@menhir \
--to=swhiteho@redhat.com \
--cc=hch@infradead.org \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).