From: Joe Perches <joe@perches.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] proc: Convert S_<FOO> permission uses to octal
Date: Fri, 12 Feb 2021 14:51:26 -0800 [thread overview]
Message-ID: <130bc5f98c2fd501d32024d267ea73f1fb9d88b6.camel@perches.com> (raw)
In-Reply-To: <m1im6x0wtv.fsf@fess.ebiederm.org>
On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote:
> Joe Perches <joe@perches.com> writes:
>
> > Convert S_<FOO> permissions to the more readable octal.
> >
> > Done using:
> > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS fs/proc/*.[ch]
> >
> > No difference in generated .o files allyesconfig x86-64
> >
> > Link:
> > https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/
>
>
> I will be frank. I don't know what 0644 means. I can never remember
> which bit is read, write or execute. So I like symbolic constants.
>
> I don't see a compelling reason to change the existing code.
Did you read Linus' message in the Link: above?
It was a reply to what Ingo Molnar suggested here:
https://lore.kernel.org/lkml/20160803081140.GA7833@gmail.com/
next prev parent reply other threads:[~2021-02-12 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 19:11 [PATCH] proc: Convert S_<FOO> permission uses to octal Joe Perches
2021-02-12 22:01 ` Eric W. Biederman
2021-02-12 22:19 ` Matthew Wilcox
2021-02-12 23:48 ` Eric W. Biederman
2021-02-13 0:42 ` Joe Perches
2021-02-12 22:51 ` Joe Perches [this message]
2021-02-12 23:44 ` Eric W. Biederman
2021-02-13 0:39 ` Joe Perches
2021-02-13 8:02 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130bc5f98c2fd501d32024d267ea73f1fb9d88b6.camel@perches.com \
--to=joe@perches.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).