From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7947DC433DB for ; Fri, 12 Feb 2021 22:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D3BA64E16 for ; Fri, 12 Feb 2021 22:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbhBLWzo (ORCPT ); Fri, 12 Feb 2021 17:55:44 -0500 Received: from smtprelay0065.hostedemail.com ([216.40.44.65]:49510 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229980AbhBLWwK (ORCPT ); Fri, 12 Feb 2021 17:52:10 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id C17B3100E7B44; Fri, 12 Feb 2021 22:51:28 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: lace96_421607427625 X-Filterd-Recvd-Size: 1786 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Fri, 12 Feb 2021 22:51:27 +0000 (UTC) Message-ID: <130bc5f98c2fd501d32024d267ea73f1fb9d88b6.camel@perches.com> Subject: Re: [PATCH] proc: Convert S_ permission uses to octal From: Joe Perches To: "Eric W. Biederman" Cc: Andrew Morton , Alexey Dobriyan , linux-fsdevel , LKML Date: Fri, 12 Feb 2021 14:51:26 -0800 In-Reply-To: References: <85ff6fd6b26aafdf6087666629bad3acc29258d8.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote: > Joe Perches writes: > > > Convert S_ permissions to the more readable octal. > > > > Done using: > > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS fs/proc/*.[ch] > > > > No difference in generated .o files allyesconfig x86-64 > > > > Link: > > https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/ > > > I will be frank. I don't know what 0644 means. I can never remember > which bit is read, write or execute. So I like symbolic constants. > > I don't see a compelling reason to change the existing code. Did you read Linus' message in the Link: above? It was a reply to what Ingo Molnar suggested here: https://lore.kernel.org/lkml/20160803081140.GA7833@gmail.com/