linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allison Henderson <achender@linux.vnet.ibm.com>
To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	xfs@oss.sgi.com
Cc: Allison Henderson <achender@linux.vnet.ibm.com>
Subject: [PATCH 1/1] XFS TESTS: Correct extent flag parsing for punch hole tests
Date: Thu, 14 Jul 2011 20:52:13 -0700	[thread overview]
Message-ID: <1310701933-18988-1-git-send-email-achender@linux.vnet.ibm.com> (raw)

The fiemap filters used in the punch hole tests parse the
extent flags in the fiemap to determine the extent type.
They are currently parsing them as decimal values, but
they should be parsing hex values.

Signed-off-by: Allison Henderson <achender@linux.vnet.ibm.com>
---
:100644 100755 0083963... 0083963... M	255
:100644 100644 a48b7ae... 7337298... M	common.punch
 common.punch |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/255 b/255
old mode 100644
new mode 100755
diff --git a/common.punch b/common.punch
index a48b7ae..7337298 100644
--- a/common.punch
+++ b/common.punch
@@ -208,11 +208,11 @@ _filter_fiemap()
 			print $1, $2, $3;
 			next;
 		}
-		$5 ~ /0x[[:digit:]]*8[[:digit:]]{2}/ {
+		$5 ~ /0x[[:xdigit:]]*8[[:xdigit:]]{2}/ {
 			print $1, $2, "unwritten";
 			next;
 		}
-		$5 ~ /0x[[:digit:]]+/ {
+		$5 ~ /0x[[:xdigit:]]+/ {
 			print $1, $2, "data";
 		}' |
 	_coalesce_extents
@@ -228,7 +228,7 @@ _filter_hole_fiemap()
 			print $1, $2, $3; 
 			next;
 		}   
-		$5 ~ /0x[[:digit:]]+/ {
+		$5 ~ /0x[[:xdigit:]]+/ {
 			print $1, $2, "extent";
 		}' |
 	_coalesce_extents
-- 
1.7.1


             reply	other threads:[~2011-07-15  3:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15  3:52 Allison Henderson [this message]
2011-07-15 13:46 ` [PATCH 1/1] XFS TESTS: Correct extent flag parsing for punch hole tests Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310701933-18988-1-git-send-email-achender@linux.vnet.ibm.com \
    --to=achender@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).