Re: [PATCH] fs:update the NOTE of the file_operations structure

Re: [PATCH] fs:update the NOTE of the file_operations structure

[Wanlong Gao]

Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.
So just remove the out-of-date NOTE.

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
 include/linux/fs.h |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..67b2b21 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1538,11 +1538,6 @@ struct block_device_operations;
 #define HAVE_COMPAT_IOCTL 1
 #define HAVE_UNLOCKED_IOCTL 1
 
-/*
- * NOTE:
- * all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
- */
 struct file_operations {
 	struct module *owner;
 	loff_t (*llseek) (struct file *, loff_t, int);
-- 
1.7.6

[PATCH] fs:update the NOTE of the file_operations structure

[Wanlong Gao]

Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
 include/linux/fs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..fdeeb3f 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1541,7 +1541,7 @@ struct block_device_operations;
 /*
  * NOTE:
  * all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
+ * the special spin_lock file_lock_lock held in all filesystems.
  */
 struct file_operations {
 	struct module *owner;
-- 
1.7.4.1

Re: [PATCH] fs:update the NOTE of the file_operations structure

[Christoph Hellwig]

>  /*
>   * NOTE:
>   * all file operations except setlease can be called without
> - * the big kernel lock held in all filesystems.
> + * the special spin_lock file_lock_lock held in all filesystems.
>   */
>  struct file_operations {
>  	struct module *owner;

I'd just remove the comment entirely.

Re: [PATCH] fs:update the NOTE of the file_operations structure

[Wanlong Gao]

On 07/19/2011 01:27 AM, Christoph Hellwig wrote:
>>   /*
>>    * NOTE:
>>    * all file operations except setlease can be called without
>> - * the big kernel lock held in all filesystems.
>> + * the special spin_lock file_lock_lock held in all filesystems.
>>    */
>>   struct file_operations {
>>   	struct module *owner;
>
> I'd just remove the comment entirely.
>
 From 765a06af4b8b4b67238e896fb6b82270d765195d Mon Sep 17 00:00:00 2001
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Date: Tue, 19 Jul 2011 08:30:17 +0800
Subject: [PATCH] fs:remove the out-of-date NOTE of file_operations structure

Big kernel lock had been removed and setlease now use the lock_flocks()
to hold a special spin lock file_lock_lock by Matthew.
So just remove the out-of-date NOTE.

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
  include/linux/fs.h |    5 -----
  1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index b5b9792..67b2b21 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1538,11 +1538,6 @@ struct block_device_operations;
  #define HAVE_COMPAT_IOCTL 1
  #define HAVE_UNLOCKED_IOCTL 1

-/*
- * NOTE:
- * all file operations except setlease can be called without
- * the big kernel lock held in all filesystems.
- */
  struct file_operations {
  	struct module *owner;
  	loff_t (*llseek) (struct file *, loff_t, int);
-- 
1.7.6


-- 
Thanks
Best Regards
Wanlong Gao