From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: Please pull NFS client changes Date: Sun, 31 Jul 2011 15:39:53 -0400 Message-ID: <1312141193.7127.1.camel@lade.trondhjem.org> References: <1312082377.10882.1.camel@lade.trondhjem.org> <20110731182406.GA16470@infradead.org> <4E35A9B1.9090309@fusionio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Christoph Hellwig , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org To: Jens Axboe Return-path: Received: from mx2.netapp.com ([216.240.18.37]:18027 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940Ab1GaTjz convert rfc822-to-8bit (ORCPT ); Sun, 31 Jul 2011 15:39:55 -0400 In-Reply-To: <4E35A9B1.9090309@fusionio.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, 2011-07-31 at 21:14 +0200, Jens Axboe wrote:=20 > On 2011-07-31 20:24, Christoph Hellwig wrote: > > How does this manage to include the pnfs block code, which only was= posted > > on the list a few hours before the pull request, and which doesn't > > appear to past testing very well (although the major issue seems to= be > > core nfs code)? >=20 > And it doesn't even compile: >=20 > In file included from fs/nfs/client.c:51:0: > fs/nfs/pnfs.h:384:1: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98{=E2=80=99 token > fs/nfs/client.c: In function =E2=80=98nfs_server_set_fsinfo=E2=80=99: > fs/nfs/client.c:939:8: error: =E2=80=98struct nfs_server=E2=80=99 has= no member named > =E2=80=98pnfs_blksize=E2=80=99 > fs/nfs/client.c: At top level: > fs/nfs/pnfs.h:382:20: warning: =E2=80=98set_pnfs_layoutdriver=E2=80=99= used but never > defined [enabled by default] > make[2]: *** [fs/nfs/client.o] Error 1 Sigh. This should fix it... 8<---------------------------------------------------------------------= ----------------=20 =46rom b74e1d98b2027aa3ec46f3612143d0d35db92cf5 Mon Sep 17 00:00:00 200= 1 =46rom: Trond Myklebust Date: Sun, 31 Jul 2011 15:33:26 -0400 Subject: [PATCH] NFS: Fix a typo in fs/nfs/pnfs.h Reported-by: Jens Axboe Signed-off-by: Trond Myklebust --- fs/nfs/pnfs.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h index e0b5d80..01cbfd5 100644 --- a/fs/nfs/pnfs.h +++ b/fs/nfs/pnfs.h @@ -380,7 +380,7 @@ pnfs_roc_drain(struct inode *ino, u32 *barrier) } =20 static inline void set_pnfs_layoutdriver(struct nfs_server *s, - const struct nfs_fh *mntfh, u32 id); + const struct nfs_fh *mntfh, u32 id) { } =20 --=20 1.7.6 --=20 Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html