From: Peter Zijlstra <peterz@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] dentry: move to per-sb LRU locks
Date: Mon, 08 Aug 2011 15:02:24 +0200 [thread overview]
Message-ID: <1312808544.10488.31.camel@twins> (raw)
In-Reply-To: <1312787021-11324-3-git-send-email-david@fromorbit.com>
On Mon, 2011-08-08 at 17:03 +1000, Dave Chinner wrote:
> + /* s_dentry_lru_lock protects s_dentry_lru, s_nr_dentry_unused */
> + spinlock_t s_dentry_lru_lock ____cacheline_aligned_in_smp;
> struct list_head s_dentry_lru; /* unused dentry lru */
Wouldn't it make sense to have both those on the same cacheline?
next prev parent reply other threads:[~2011-08-08 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 7:03 [PATCH 0/2] dcache: per-sb LRU locks Dave Chinner
2011-08-08 7:03 ` [PATCH 1/2] dcache: convert dentry_stat.nr_unused to per-cpu counters Dave Chinner
2011-08-08 7:08 ` Pekka Enberg
2011-08-09 10:48 ` Dave Chinner
2011-08-08 7:03 ` [PATCH 2/2] dentry: move to per-sb LRU locks Dave Chinner
2011-08-08 13:02 ` Peter Zijlstra [this message]
2011-08-09 11:04 ` Dave Chinner
2011-08-09 11:21 ` Peter Zijlstra
2011-08-10 5:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312808544.10488.31.camel@twins \
--to=peterz@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).