From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] net/9p: Convert net/9p protocol dumps to tracepoints
Date: Tue, 09 Aug 2011 10:39:13 -0400
Message-ID: <1312900753.18583.251.camel@gandalf.stny.rr.com>
References: <1312890773-15305-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	 <CAOJsxLHDg8+QUFu68NBQoq8EgrgapTE15sFXQucw+pyDXV0tLQ@mail.gmail.com>
	 <87r54u92ok.fsf@skywalker.in.ibm.com> <1312894395.3064.23.camel@fedora>
	 <87obzy8xrd.fsf@skywalker.in.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>,
	v9fs-developer@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:39438 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750695Ab1HIOjS (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 9 Aug 2011 10:39:18 -0400
In-Reply-To: <87obzy8xrd.fsf@skywalker.in.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 2011-08-09 at 19:58 +0530, Aneesh Kumar K.V wrote:
> On Tue, 09 Aug 2011 08:53:15 -0400, Steven Rostedt <srostedt@redhat.com> wrote:

> > > +	    TP_printk("clnt %lu %s(tag = %d)\n%.8x: %s\n%.8x: %s\n",
> > > +		      (long)__entry->clnt, show_9p_op(__entry->type),
> > > +		      __entry->tag, 0, __entry->line1, 16 , __entry->line2)
> > 
> > Yeah, you would need to make the above ugly to print out the array, but
> > it's not that hard. And you will be saving 102 bytes per event in the
> > ring buffer, which is very expensive real-estate. Not to mention the
> > time it takes to copy all that.
> > 
> 
> Any suggestion on how to get this pretty printing of the hex data. I can
> update print_hex_dump_bytes to dump the hex data to a buffer. But not
> sure where i can free the buffer after using that in TP_printk. 

By making it very ugly :)

	TP_printk("clnt %lu %s(tag = %d)\n%.8x: "
		"%02x %02x %02x %02x %02x %02x %02x %02x %02x "
		"%02x %02x %02x %02x %02x %02x %02x %02x %02x\n"
		"%.8x: "
		"%02x %02x %02x %02x %02x %02x %02x %02x %02x "
		"%02x %02x %02x %02x %02x %02x %02x %02x %02x\n",
		(long)__entry->clnt, show_9p_op(__entry->type),
		__entry->tag, 0,
		__entry->line1[0], __entry->line1[1],
		__entry->line1[2], __entry->line1[3],
		__entry->line1[4], __entry->line1[5],
		__entry->line1[6], __entry->line1[7],
		__entry->line1[8], __entry->line1[9],
		__entry->line1[10], __entry->line1[11],
		__entry->line1[12], __entry->line1[13],
		__entry->line1[14], __entry->line1[15],
		16,
		__entry->line2[0], __entry->line2[1],
		__entry->line2[2], __entry->line2[3],
		__entry->line2[4], __entry->line2[5],
		__entry->line2[6], __entry->line2[7],
		__entry->line2[8], __entry->line2[9],
		__entry->line2[10], __entry->line2[11],
		__entry->line2[12], __entry->line2[13],
		__entry->line2[14], __entry->line2[15])


Like I said, it's not pretty, but it saves buffer space and moves the
slow copy out of the fast path.

-- Steve