From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 17/18] writeback: fix dirtied pages accounting on redirty
Date: Tue, 06 Sep 2011 18:18:56 +0200
Message-ID: <1315325936.14232.22.camel@twins>
References: <20110904015305.367445271@intel.com>
	 <20110904020916.841463184@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: linux-fsdevel@vger.kernel.org, Andrew Morton
 <akpm@linux-foundation.org>,  Jan Kara <jack@suse.cz>, Christoph Hellwig
 <hch@lst.de>, Dave Chinner <david@fromorbit.com>, Greg Thelen
 <gthelen@google.com>, Minchan Kim <minchan.kim@gmail.com>, Vivek Goyal
 <vgoyal@redhat.com>,  Andrea Righi <arighi@develer.com>, linux-mm
 <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Return-path: <owner-linux-mm@kvack.org>
In-Reply-To: <20110904020916.841463184@intel.com>
Sender: owner-linux-mm@kvack.org
List-Id: linux-fsdevel.vger.kernel.org

On Sun, 2011-09-04 at 09:53 +0800, Wu Fengguang wrote:
> De-account the accumulative dirty counters on page redirty.
>=20
> Page redirties (very common in ext4) will introduce mismatch between
> counters (a) and (b)
>=20
> a) NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied
> b) NR_WRITTEN, BDI_WRITTEN
>=20
> This will introduce systematic errors in balanced_rate and result in
> dirty page position errors (ie. the dirty pages are no longer balanced
> around the global/bdi setpoints).
>=20

So wtf is ext4 doing? Shouldn't a page stay dirty until its written out?

That is, should we really frob around this behaviour or fix ext4 because
its on crack?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>