From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Cross Subject: [PATCH 0/3] Replace kmalloc with vmalloc in seq_files Date: Thu, 22 Sep 2011 13:57:06 -0700 Message-ID: <1316725029-22737-1-git-send-email-ccross@android.com> Cc: linux-fsdevel@vger.kernel.org, Alexander Viro , Ingo Molnar , Peter Zijlstra , Andrew Morton , Alexey Dobriyan , Colin Cross To: linux-kernel@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org When a seq_file is implemented with single_open, the show function will be called with a kmalloc'd PAGE_SIZE buffer. If the show function produces more data than can fit in the buffer, the buffer will be thrown away, and the show function will be called again with a buffer twice as large. This process repeats until the show function does not overflow the buffer, or kmalloc fails. seq_files are often used for debugging data. When the system is under memory pressure, and dumping debugging data starts trying to allocate large physically contiguous buffers, it often makes the problem worse. Since there is no need for a physically contiguous buffer, this patch set converts the kmalloc'd buffers into vmallocs. There are two seq_file users that kmalloc buffer and place it directly into the seq_file structure, later to be freed by seq_release. Convert those to call a new seq_reserve function that will do the correct allocation for them.