From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/3] Replace kmalloc with vmalloc in seq_files
Date: Thu, 22 Sep 2011 23:22:49 +0200
Message-ID: <1316726569.31040.37.camel@twins>
References: <1316725029-22737-1-git-send-email-ccross@android.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@gmail.com>
To: Colin Cross <ccross@android.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from casper.infradead.org ([85.118.1.10]:50910 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753914Ab1IVVXP convert rfc822-to-8bit (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 22 Sep 2011 17:23:15 -0400
In-Reply-To: <1316725029-22737-1-git-send-email-ccross@android.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2011-09-22 at 13:57 -0700, Colin Cross wrote:
> 
> seq_files are often used for debugging data.  When the system is under
> memory pressure, and dumping debugging data starts trying to allocate
> large physically contiguous buffers, it often makes the problem
> worse. 

Shouldn't you be using ->next instead of dumping everything in a single
seqop? That way it can return partial buffers and keep state etc.