From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH 10/13] filesystems: add set_nlink() Date: Thu, 13 Oct 2011 17:33:19 +0100 Message-ID: <1318523599.2719.45.camel@menhir> References: <1318430946-7091-1-git-send-email-miklos@szeredi.hu> <1318430946-7091-11-git-send-email-miklos@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, akpm@linux-foundation.org, toshi.okajima@jp.fujitsu.com, mszeredi@suse.cz To: Miklos Szeredi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33411 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135Ab1JMQcY (ORCPT ); Thu, 13 Oct 2011 12:32:24 -0400 In-Reply-To: <1318430946-7091-11-git-send-email-miklos@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Wed, 2011-10-12 at 16:49 +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Replace remaining direct i_nlink updates with a new set_nlink() > updater function. > > Signed-off-by: Miklos Szeredi > --- [snip] > diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c > index da21eca..102cf5e 100644 > --- a/fs/gfs2/glops.c > +++ b/fs/gfs2/glops.c > @@ -277,7 +277,7 @@ static void gfs2_set_nlink(struct inode *inode, u32 nlink) > if (nlink == 0) > clear_nlink(inode); > else > - inode->i_nlink = nlink; > + set_nlink(inode, nlink); > } > } So long as it is ok to call set_nlink() with nlink == 0, then the if statement here can be removed and just replaced with set_nlink() Steve.