linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Monakhov <dmonakhov@openvz.org>
To: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Cc: hch@lst.de, david@fromorbit.com, Dmitry Monakhov <dmonakhov@openvz.org>
Subject: [PATCH 2/3] xfstests: fix typo in 260'th test
Date: Tue,  8 Nov 2011 12:41:54 +0400	[thread overview]
Message-ID: <1320741715-32692-2-git-send-email-dmonakhov@openvz.org> (raw)
In-Reply-To: <1320741715-32692-1-git-send-email-dmonakhov@openvz.org>

dd should not have count argument because it suposed to work untill ENOSPC.
Also it is reasonable to log dd's output, do that for both 269'th and 270'th
tests

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 269 |    4 ++--
 270 |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/269 b/269
index 61e83ad..206492b 100755
--- a/269
+++ b/269
@@ -53,8 +53,8 @@ _workout()
 	for ((i=0; i < num_iterations; i++))
 	do
 		# File will be opened with O_TRUNC each time
-		dd if=/dev/zero of=$SCRATCH_MNT/SPACE_CONSUMER bs=1M count=1 \
-			> /dev/null 2>&1
+		dd if=/dev/zero of=$SCRATCH_MNT/SPACE_CONSUMER bs=1M \
+			>> $here/$seq.full 2>&1
 		sleep $enospc_time
 	done
 	kill $pid
diff --git a/270 b/270
index ed1e31e..e45029f 100755
--- a/270
+++ b/270
@@ -63,7 +63,7 @@ _workout()
 		# File will be opened with O_TRUNC each time
 		su $qa_user -c "dd if=/dev/zero \
 			of=$SCRATCH_MNT/SPACE_CONSUMER bs=1M " \
-			> /dev/null 2>&1
+			>> $here/$seq.full 2>&1
 		sleep $enospc_time
 	done
 
-- 
1.7.1


  reply	other threads:[~2011-11-08  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  8:41 [PATCH 1/3] xfstests: fix argument typo Dmitry Monakhov
2011-11-08  8:41 ` Dmitry Monakhov [this message]
2011-11-08  8:41 ` [PATCH 3/3] xfstests: remove duplicated umount $scratch_dev Dmitry Monakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320741715-32692-2-git-send-email-dmonakhov@openvz.org \
    --to=dmonakhov@openvz.org \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).