* [PATCH] fs : remove unneeded plug in mpage_readpages.
@ 2011-11-11 15:54 Namjae Jeon
2011-11-17 8:52 ` Amit Sahrawat
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2011-11-11 15:54 UTC (permalink / raw)
To: viro; +Cc: linux-kernel, linux-fsdevel, Namjae Jeon, Amit Sahrawat
block plug in mpage_readpages is duplicated with plug of read_pages. So block plug is not needed in mpage_readpages.
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
fs/mpage.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index fdfae9f..643e9f5 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -371,9 +371,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages,
sector_t last_block_in_bio = 0;
struct buffer_head map_bh;
unsigned long first_logical_block = 0;
- struct blk_plug plug;
-
- blk_start_plug(&plug);
map_bh.b_state = 0;
map_bh.b_size = 0;
@@ -395,7 +392,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages,
BUG_ON(!list_empty(pages));
if (bio)
mpage_bio_submit(READ, bio);
- blk_finish_plug(&plug);
return 0;
}
EXPORT_SYMBOL(mpage_readpages);
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs : remove unneeded plug in mpage_readpages.
2011-11-11 15:54 [PATCH] fs : remove unneeded plug in mpage_readpages Namjae Jeon
@ 2011-11-17 8:52 ` Amit Sahrawat
0 siblings, 0 replies; 2+ messages in thread
From: Amit Sahrawat @ 2011-11-17 8:52 UTC (permalink / raw)
To: Namjae Jeon; +Cc: viro, linux-kernel, linux-fsdevel
Any feedback for this patch?
Thanks & Regards,
Amit Sahrawat
On Fri, Nov 11, 2011 at 9:24 PM, Namjae Jeon <linkinjeon@gmail.com> wrote:
> block plug in mpage_readpages is duplicated with plug of read_pages. So block plug is not needed in mpage_readpages.
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/mpage.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/fs/mpage.c b/fs/mpage.c
> index fdfae9f..643e9f5 100644
> --- a/fs/mpage.c
> +++ b/fs/mpage.c
> @@ -371,9 +371,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages,
> sector_t last_block_in_bio = 0;
> struct buffer_head map_bh;
> unsigned long first_logical_block = 0;
> - struct blk_plug plug;
> -
> - blk_start_plug(&plug);
>
> map_bh.b_state = 0;
> map_bh.b_size = 0;
> @@ -395,7 +392,6 @@ mpage_readpages(struct address_space *mapping, struct list_head *pages,
> BUG_ON(!list_empty(pages));
> if (bio)
> mpage_bio_submit(READ, bio);
> - blk_finish_plug(&plug);
> return 0;
> }
> EXPORT_SYMBOL(mpage_readpages);
> --
> 1.7.4.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-17 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11 15:54 [PATCH] fs : remove unneeded plug in mpage_readpages Namjae Jeon
2011-11-17 8:52 ` Amit Sahrawat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).