linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, adilger@dilger.ca
Subject: [PATCH V2 14/19] ext4: let ext4_find_entry handle inline data.
Date: Tue, 22 Nov 2011 00:39:52 +0800	[thread overview]
Message-ID: <1321893597-11024-14-git-send-email-tm@tao.ma> (raw)
In-Reply-To: <1321893597-11024-1-git-send-email-tm@tao.ma>

From: Tao Ma <boyu.mt@taobao.com>

Create a new ext4_find_inline_entry to handle the case
of inline data.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/ext4/inline.c |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 fs/ext4/namei.c  |   10 +++++++++-
 fs/ext4/xattr.h  |   12 ++++++++++++
 3 files changed, 68 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index a6b6593..c76ae3b 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1308,6 +1308,53 @@ out:
 	return ret;
 }
 
+struct buffer_head *ext4_find_inline_entry(struct inode *dir,
+					const struct qstr *d_name,
+					struct ext4_dir_entry_2 **res_dir,
+					int *has_inline_data)
+{
+	int ret;
+	struct ext4_iloc iloc;
+	void *inline_start;
+	int inline_size;
+
+	if (ext4_get_inode_loc(dir, &iloc))
+		return NULL;
+
+	down_read(&EXT4_I(dir)->xattr_sem);
+	if (!ext4_has_inline_data(dir)) {
+		*has_inline_data = 0;
+		goto out;
+	}
+
+	inline_start = ext4_raw_inode(&iloc)->i_block;
+	inline_size = EXT4_MIN_INLINE_DATA_SIZE;
+	ret = search_dir(iloc.bh, inline_start, inline_size,
+			 dir, d_name, 0, res_dir);
+	if (ret == 1)
+		goto out_find;
+	if (ret < 0)
+		goto out;
+
+	if (ext4_get_inline_size(dir) == EXT4_MIN_INLINE_DATA_SIZE)
+		goto out;
+
+	inline_start = ext4_get_inline_xattr_pos(dir, &iloc);
+	inline_size = ext4_get_max_inline_size(dir);
+
+	ret = search_dir(iloc.bh, inline_start, inline_size,
+			 dir, d_name, 0, res_dir);
+	if (ret == 1)
+		goto out_find;
+
+out:
+	brelse(iloc.bh);
+	iloc.bh = NULL;
+out_find:
+	up_read(&EXT4_I(dir)->xattr_sem);
+	return iloc.bh;
+}
+
 int ext4_destroy_inline_data(handle_t *handle, struct inode *inode)
 {
 	int ret;
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 6e97dd2..92f7b67 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -844,7 +844,6 @@ static inline int search_dirblock(struct buffer_head *bh,
 			  d_name, offset, res_dir);
 }
 
-
 /*
  *	ext4_find_entry()
  *
@@ -879,6 +878,15 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
 	namelen = d_name->len;
 	if (namelen > EXT4_NAME_LEN)
 		return NULL;
+
+	if (ext4_has_inline_data(dir)) {
+		int has_inline_data = 1;
+		ret = ext4_find_inline_entry(dir, d_name, res_dir,
+					     &has_inline_data);
+		if (has_inline_data)
+			return ret;
+	}
+
 	if ((namelen <= 2) && (name[0] == '.') &&
 	    (name[1] == '.' || name[1] == '\0')) {
 		/*
diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
index 1e042b4..f4d4cb1 100644
--- a/fs/ext4/xattr.h
+++ b/fs/ext4/xattr.h
@@ -170,6 +170,10 @@ extern int ext4_try_create_inline_dir(handle_t *handle,
 				      struct inode *inode);
 extern int ext4_read_inline_dir(struct file *filp,
 				void *dirent, filldir_t filldir);
+extern struct buffer_head *ext4_find_inline_entry(struct inode *dir,
+					const struct qstr *d_name,
+					struct ext4_dir_entry_2 **res_dir,
+					int *has_inline_data);
 # else  /* CONFIG_EXT4_FS_XATTR */
 
 static inline int
@@ -358,6 +362,14 @@ static inline int ext4_read_inline_dir(struct file *filp,
 {
 	return 0;
 }
+
+struct buffer_head *ext4_find_inline_entry(struct inode *dir,
+					const struct qstr *d_name,
+					struct ext4_dir_entry_2 **res_dir,
+					int *has_inline_data)
+{
+	return NULL;
+}
 # endif  /* CONFIG_EXT4_FS_XATTR */
 
 #ifdef CONFIG_EXT4_FS_SECURITY
-- 
1.7.0.4


  parent reply	other threads:[~2011-11-21 17:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 16:34 [PATCH V2 00/19] ext4: Add inline data support Tao Ma
2011-11-21 16:39 ` [PATCH V2 01/19] ext4: Move extra inode read to a new function Tao Ma
2011-11-21 16:39   ` [PATCH V2 02/19] ext4: export inline xattr functions Tao Ma
2011-11-21 16:39   ` [PATCH V2 03/19] ext4: Add the basic function for inline data support Tao Ma
2011-11-21 16:39   ` [PATCH V2 04/19] ext4: Add read support for inline data Tao Ma
2011-11-21 16:39   ` [PATCH V2 05/19] ext4: Add normal write " Tao Ma
2011-11-21 16:39   ` [PATCH V2 06/19] ext4: Add journalled " Tao Ma
2011-11-21 16:39   ` [PATCH V2 07/19] ext4: Add delalloc " Tao Ma
2011-11-21 16:39   ` [PATCH V2 08/19] ext4: Create a new function ext4_init_new_dir Tao Ma
2011-11-21 16:39   ` [PATCH V2 09/19] ext4: Refactor __ext4_check_dir_entry to accepts start and size Tao Ma
2011-11-21 16:39   ` [PATCH V2 10/19] ext4: Create __ext4_insert_dentry for dir entry insertion Tao Ma
2011-11-21 16:39   ` [PATCH V2 11/19] ext4: let add_dir_entry handle inline data properly Tao Ma
2011-11-21 16:39   ` [PATCH V2 12/19] ext4: Let ext4_readdir handle inline data Tao Ma
2011-11-21 16:39   ` [PATCH V2 13/19] ext4: Create a new function search_dir Tao Ma
2011-11-21 16:39   ` Tao Ma [this message]
2011-11-21 16:39   ` [PATCH V2 15/19] ext4: make ext4_delete_entry generic Tao Ma
2011-11-21 16:39   ` [PATCH V2 16/19] ext4: let ext4_delete_entry handle inline data Tao Ma
2011-11-21 16:39   ` [PATCH V2 17/19] ext4: let empty_dir handle inline dir Tao Ma
2011-11-21 16:39   ` [PATCH V2 18/19] ext4: let ext4_rename " Tao Ma
2011-11-21 16:39   ` [PATCH V2 19/19] ext4: Enable ext4 inline support Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321893597-11024-14-git-send-email-tm@tao.ma \
    --to=tm@tao.ma \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).