Re: [PATCH 00/16] Permit filesystem local caching [try #3]

[David Howells <dhowells@redhat.com>]

Casey Schaufler <casey@schaufler-ca.com> wrote:

> >   (1) int security_get_context(void **_context);
> > 
> > 	This allocates and gives the caller a blob that describes the current
> > 	context of all the LSM module states attached to the current task and
> > 	stores a pointer to it in *_context.
> 
> Is this intended to be anything more than a copy of current->security?

It has to be sufficient to fully effect security_push().

> I assume that you're talking about the LSM specific data changing,
> not the LSM itself.

Yes.

> If you change the task->security information you are definitly going
> to change what other tasks can do to the calling task.

I dealt with that in my current act-as patch.  Under SELinux a task has two
primary labels.  One with which it is labelled and is used to govern effects
upon it, and one that is used to act upon things and follows changes to the
former.

> >   (5) int security_xfrm_to_kernel_context(void *from, void **_to);
> 
> Woof. What are you transforming from? 

In CacheFiles case, the cachefilesd daemon's security label into the label the
cache driver acts as on behalf of other processes.

> That's the really nice thing about cans of worms.
> They come in six-packs.

Yeah...

David