From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 16/28] namespace: checkpatch wanking Date: Tue, 29 Nov 2011 19:39:11 -0800 Message-ID: <1322624351.17214.5.camel@Joe-Laptop> References: <20111130022245.GS2203@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Al Viro Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:53648 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752076Ab1K3DjN (ORCPT ); Tue, 29 Nov 2011 22:39:13 -0500 In-Reply-To: <20111130022245.GS2203@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2011-11-30 at 02:22 +0000, Al Viro wrote: > On Tue, Nov 29, 2011 at 06:14:14PM -0800, Joe Perches wrote: > > Fix a few style things. > > $ ./scripts/checkpatch.pl -f --terse --nosummary fs/namespace.c | \ > > cut -f3- -d":" | sort | uniq -c > > 1 ERROR: do not initialise statics to 0 or NULL > > 2 ERROR: do not use assignment in if condition > > 1 ERROR: "foo * bar" should be "foo *bar" > > 1 ERROR: need consistent spacing around '|' (ctx:VxW) > > 1 WARNING: braces {} are not necessary for single statement blocks > > 3 WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > > 4 WARNING: line over 80 characters > > 9 WARNING: please, no space before tabs > > 1 WARNING: Use #include instead of > > 1 WARNING: Use #include instead of > NAK. First of all, wanking it certainly is; moreover, it creates shitloads > of conflicts with patches in vfs.git#vfsmount-guts No worries. I think patches 1 thru 14 are reasonable though and do apply with a few offsets to vfsmount-guts.