From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH v2] pipe: Fail cleanly when root tries F_SETPIPE_SZ with big size Date: Fri, 02 Dec 2011 19:47:05 +0200 Message-ID: <1322848025.3780.8.camel@lappy> References: <1321688059-3844-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org To: Pekka Enberg Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Al, Ping? On Sat, 2011-11-19 at 10:06 +0200, Pekka Enberg wrote: > On Sat, Nov 19, 2011 at 9:34 AM, Sasha Levin wrote: > > When a user with the CAP_SYS_RESOURCE cap tries to F_SETPIPE_SZ a pipe with > > size bigger than what kmalloc() can alloc it spits out an ugly warning: > > [snip] > > > Instead, make kcalloc() handle the overflow case and fail quietly. > > > > Cc: Alexander Viro > > Cc: Pekka Enberg > > Cc: linux-fsdevel@vger.kernel.org > > Signed-off-by: Sasha Levin > > Acked-by: Pekka Enberg > > > --- > > fs/pipe.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/fs/pipe.c b/fs/pipe.c > > index 4065f07..3e38dc6 100644 > > --- a/fs/pipe.c > > +++ b/fs/pipe.c > > @@ -1137,7 +1137,7 @@ static long pipe_set_size(struct pipe_inode_info *pipe, unsigned long nr_pages) > > if (nr_pages < pipe->nrbufs) > > return -EBUSY; > > > > - bufs = kcalloc(nr_pages, sizeof(struct pipe_buffer), GFP_KERNEL); > > + bufs = kcalloc(nr_pages, sizeof(struct pipe_buffer), GFP_KERNEL | __GFP_NOWARN); > > if (unlikely(!bufs)) > > return -ENOMEM; > > > > -- > > 1.7.8.rc1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > -- Sasha.