From: Artem Bityutskiy <dedekind1@gmail.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked
Date: Thu, 08 Dec 2011 23:54:43 +0200 [thread overview]
Message-ID: <1323381285.2074.4.camel@koala> (raw)
In-Reply-To: <4EDE9FDE.3040109@sandeen.net>
On Tue, 2011-12-06 at 17:06 -0600, Eric Sandeen wrote:
> after 250df6ed274d767da844a5d9f05720b804240197
> (fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
> no longer returns the inode with I_NEW set on failure. However,
> the error handler still calls unlock_new_inode() on failure,
> which does a WARN_ON if I_NEW is not set, so any failure spews
> a lot of warnings.
>
> We can just drop the unlock_new_inode() if insert_inode_locked()
> fails here.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Pushed to l2-mtd-2.6.git tree, thanks!
Artem.
next prev parent reply other threads:[~2011-12-08 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 22:55 [PATCH 0/6] fs: fix up error handlers for insert_inode_locked Eric Sandeen
2011-12-06 22:57 ` [PATCH 1/6] ext2: fix up error handling " Eric Sandeen
2011-12-06 23:18 ` [PATCH 1/6 v2] " Eric Sandeen
2011-12-06 22:59 ` [PATCH 2/6] ext3: " Eric Sandeen
2011-12-06 23:19 ` [PATCH 2/6 V2] " Eric Sandeen
2011-12-06 23:02 ` [PATCH 3/6] ext4: " Eric Sandeen
2011-12-06 23:19 ` [PATCH 3/6 V2] " Eric Sandeen
2011-12-06 23:06 ` [PATCH 4/6] jffs2: " Eric Sandeen
2011-12-08 21:54 ` Artem Bityutskiy [this message]
2011-12-06 23:10 ` [PATCH 5/6] jfs: " Eric Sandeen
2011-12-06 23:12 ` [PATCH 6/6] reiserfs: fix up error handling for insert_inode_locked4 Eric Sandeen
2011-12-06 23:13 ` [PATCH 0/6] fs: fix up error handlers for insert_inode_locked Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323381285.2074.4.camel@koala \
--to=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).