From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 4/6] jffs2: fix up error handling for insert_inode_locked
Date: Thu, 08 Dec 2011 23:54:43 +0200
Message-ID: <1323381285.2074.4.camel@koala>
References: <4EDE9D54.1030506@redhat.com> <4EDE9FDE.3040109@sandeen.net>
Reply-To: dedekind1@gmail.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	linux-mtd@lists.infradead.org
To: Eric Sandeen <sandeen@sandeen.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:37820 "EHLO
	mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753230Ab1LHVyr (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 8 Dec 2011 16:54:47 -0500
Received: by lagp5 with SMTP id p5so881438lag.19
        for <linux-fsdevel@vger.kernel.org>; Thu, 08 Dec 2011 13:54:46 -0800 (PST)
In-Reply-To: <4EDE9FDE.3040109@sandeen.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 2011-12-06 at 17:06 -0600, Eric Sandeen wrote:
> after 250df6ed274d767da844a5d9f05720b804240197
> (fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
> no longer returns the inode with I_NEW set on failure.  However,
> the error handler still calls unlock_new_inode() on failure,
> which does a WARN_ON if I_NEW is not set, so any failure spews
> a lot of warnings.
> 
> We can just drop the unlock_new_inode() if insert_inode_locked()
> fails here.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Pushed to l2-mtd-2.6.git tree, thanks!

Artem.