From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [RFC] killing boilerplate checks in ->link/->mkdir/->rename Date: Fri, 03 Feb 2012 21:34:53 +0200 Message-ID: <1328297704.2107.3.camel@koala> References: <20120202012258.GQ23916@ZenIV.linux.org.uk> <20120202212400.GR23916@ZenIV.linux.org.uk> <20120203011612.GS23916@ZenIV.linux.org.uk> <20120203170825.GX23916@ZenIV.linux.org.uk> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-FmJcqI7s6gvcKZl2wtZH" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds To: Al Viro Return-path: In-Reply-To: <20120203170825.GX23916@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-FmJcqI7s6gvcKZl2wtZH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-02-03 at 17:08 +0000, Al Viro wrote: > On Fri, Feb 03, 2012 at 01:16:12AM +0000, Al Viro wrote: >=20 > > * ubifs, hfsplus, jffs2 - definitely broken if you create enough > > links. i_nlink wraparound to zero, confused inode eviction logics. >=20 > BTW, ubifs plays funny games with i_nlink - decrements it early in > unlink/rmdir/rename and then increments it back on failure. *If* > we really want it that way, we need to use set_nlink() there. Frankly, > I'd rather deal with drop_nlink() after the last possible failure > exit... Unless there are serious reasons why that wouldn't work, that is= . There was a good reason for those games. I cannot provide a good explanation right now because I need to refresh my memory (but I am sure there must be a big comment in the code about this) and my daughter is getting upset already because I am typing something instead of playing with her. Will try to answer on Monday. Have a nice weekend! --=20 Best Regards, Artem Bityutskiy --=-FmJcqI7s6gvcKZl2wtZH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAABAgAGBQJPLDbeAAoJEJtuLFy+q7femfgH/2ZFbUXY/BKJ3QjnwdZpsEu9 MICacIp6S/55aq1k66LLyxwGTQwG+eJgeybizo2nlmnOxNCswewweeFjBkyX3uaY 1aAd/+UpctQ4FcXjusvU/SwSo8JzwC1qwQsxqfam4qU7m+mRoXrr2qtrSSDulZ3E IyqodlvmmNUlvp2erZLMVbcuMlvKBwN93hZupKJ0G2tajJQR/SfXquZFc1siRfYX E7Jo1EyMPYnhCwZEh4V8r+Nc+PM/N1W0LWHXZX+2vFFyrMuOgh5wl8QXB1Km7SdH W9syAiwg/as8sMr+Xb80AU9m3Z+ABdQNmJlDSlDII2GyWmoiFClAtfjqXJ5g1Mw= =d8Z1 -----END PGP SIGNATURE----- --=-FmJcqI7s6gvcKZl2wtZH--