From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] cpumask: fix lg_lock/br_lock. Date: Wed, 29 Feb 2012 09:58:14 +0100 Message-ID: <1330505894.11248.108.camel@twins> References: <87ehtf3lqh.fsf@rustcorp.com.au> <20120227155338.7b5110cd.akpm@linux-foundation.org> <20120228084359.GJ21106@elte.hu> <20120228132719.f375071a.akpm@linux-foundation.org> <20120229082944.GA10425@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Andrew Morton , Rusty Russell , Nick Piggin , linux-kernel , Alexander Viro , Andi Kleen , "Srivatsa S. Bhat" , linux-fsdevel@vger.kernel.org To: Ingo Molnar Return-path: In-Reply-To: <20120229082944.GA10425@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2012-02-29 at 09:29 +0100, Ingo Molnar wrote: > As part of any cleanup they should first be converted from > arch_spinlock_t to regular spinlock_t - I bet if that is done > then that not only simplifies the wrappers massively, it also > turns the above soft lockup report into a nice, actionable > lockdep splat. It might help if you'd actually read the code.. that will simply not work.