From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch] Move CRC computation to separate function
Date: Wed, 29 Feb 2012 18:10:26 +0200 [thread overview]
Message-ID: <1330531826.3545.128.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1202202112220.21022@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
On Mon, 2012-02-20 at 21:15 +0100, Joel Reardon wrote:
> This patch moves the computation of CRCs for data nodes from
> within ubifs_prepare_node to a separate function ubifs_set_datanode_crc,
> which takes a data node, and computes and sets the CRC. This is to avoid
> duplication of the CRC computation code in other places where it may be
> needed.
>
> Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>
> diff -uprN -X linux-3.2.1-vanilla/Documentation/dontdiff
> linux-3.2.1-vanilla/fs/ubifs/io.c linux-3.2.1-ubifsec/fs/ubifs/io.c
> --- linux-3.2.1-vanilla/fs/ubifs/io.c 2012-01-12 20:42:45.000000000
> +0100
> +++ linux-3.2.1-ubifsec/fs/ubifs/io.c 2012-02-20 20:17:48.796684293
> +0100
> @@ -367,6 +367,18 @@ static unsigned long long next_sqnum(str
> }
This patch is line-wrapped and cannot be applied. Would you please send
a non-wrapped version. You may experiment by sending to yourself, then
saving, and then applying using "git am".
>
> /**
> + * ubifs_set_datanode_crc - writes the crc for a data node to the common
> + * header.
> + * @node: the data node
> + */
> +void ubifs_set_datanode_crc(void *node)
> +{
> + struct ubifs_ch *ch = (struct ubifs_ch *) node;
> + int len = le32_to_cpu(ch->len);
> + ch->crc = cpu_to_le32(crc32(UBIFS_CRC32_INIT, node + 8, len - 8));
> +}
This changes is not needed unless there is other code which needs this
function. So once I get a non-wrapped patch I can create a branch for
you in the UBIFS tree and collect your patches. Once they are ready,
they can be merged.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-29 16:08 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 15:24 [patch] Adding Secure Deletion to UBIFS Joel Reardon
2012-02-13 16:54 ` Artem Bityutskiy
2012-02-23 14:59 ` Joel Reardon
2012-02-23 15:29 ` [patch] Add encryption key parameter to compress/decompress functions Joel Reardon
2012-03-09 7:17 ` Artem Bityutskiy
2012-03-19 16:54 ` [patch] Add design document for UBIFS secure deletion Joel Reardon
2012-03-20 20:10 ` Randy Dunlap
2012-03-21 13:26 ` Joel Reardon
2012-03-21 16:20 ` Artem Bityutskiy
2012-03-21 16:10 ` Artem Bityutskiy
2012-03-23 13:50 ` Joel Reardon
2012-03-23 15:38 ` Artem Bityutskiy
2012-03-23 16:38 ` Joel Reardon
2012-03-26 15:03 ` Artem Bityutskiy
2012-02-29 17:09 ` [patch] Adding Secure Deletion to UBIFS Artem Bityutskiy
2012-03-15 14:48 ` [patch] Remove notion of key schemes Joel Reardon
2012-03-16 12:43 ` Artem Bityutskiy
2012-03-16 12:51 ` Artem Bityutskiy
2012-03-16 13:34 ` Joel Reardon
2012-03-16 13:41 ` Artem Bityutskiy
2012-03-16 15:02 ` Joel Reardon
2012-03-19 14:56 ` Artem Bityutskiy
2012-02-20 20:15 ` [patch] Move CRC computation to separate function Joel Reardon
2012-02-29 16:10 ` Artem Bityutskiy [this message]
2012-03-19 22:46 ` Joel Reardon
2012-03-23 14:09 ` Artem Bityutskiy
2012-03-23 16:45 ` Joel Reardon
2012-03-23 16:51 ` Artem Bityutskiy
2012-03-25 20:38 ` Joel Reardon
2012-03-26 15:34 ` Artem Bityutskiy
2012-03-25 21:11 ` [patch] Add a encryption key parameter to the compress / decompress function Joel Reardon
2012-03-25 21:38 ` [patch] Add cryptographic functionality when a key is passed to the compress / decompress functions Joel Reardon
2012-03-27 8:33 ` Artem Bityutskiy
2012-03-29 14:39 ` [patch] UBIFS: " Joel Reardon
2012-04-02 14:36 ` Artem Bityutskiy
2012-04-02 14:48 ` Joel Reardon
2012-04-02 14:57 ` Artem Bityutskiy
2012-04-02 14:58 ` Joel Reardon
2012-04-03 10:29 ` Joel Reardon
2012-04-03 10:41 ` Guillaume LECERF
2012-04-03 11:35 ` Joel Reardon
2012-03-27 8:27 ` [patch] Add a encryption key parameter to the compress / decompress function Artem Bityutskiy
2012-03-29 14:11 ` [patch] UBIFS: " Joel Reardon
2012-04-02 14:02 ` Artem Bityutskiy
2012-02-29 17:25 ` [patch] Adding Secure Deletion to UBIFS Artem Bityutskiy
2012-03-01 13:41 ` Joel Reardon
2012-03-09 7:36 ` Artem Bityutskiy
2012-03-09 19:29 ` Joel Reardon
2012-03-12 13:30 ` Artem Bityutskiy
2012-03-12 13:34 ` Joel Reardon
2012-03-12 13:36 ` Artem Bityutskiy
2012-03-12 13:37 ` Joel Reardon
2012-03-14 10:20 ` Joel Reardon
2012-03-14 10:27 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330531826.3545.128.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).