From: "J. Bruce Fields" <bfields@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 6/7] locks: break delegations on link
Date: Fri, 9 Mar 2012 17:29:33 -0500 [thread overview]
Message-ID: <1331332174-22621-6-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <20120309222114.GA22423@fieldses.org>
From: "J. Bruce Fields" <bfields@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/namei.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 21a1d65..6f1dbfa 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2920,8 +2920,11 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
/* Make sure we don't allow creating hardlink to an unlinked file */
if (inode->i_nlink == 0)
error = -ENOENT;
- else
- error = dir->i_op->link(old_dentry, dir, new_dentry);
+ else {
+ error = break_deleg(inode, O_WRONLY);
+ if (!error)
+ error = dir->i_op->link(old_dentry, dir, new_dentry);
+ }
mutex_unlock(&inode->i_mutex);
if (!error)
fsnotify_link(dir, inode, new_dentry);
--
1.7.5.4
next prev parent reply other threads:[~2012-03-09 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 22:38 [PATCH] vfs: take i_mutex on renamed file J. Bruce Fields
2012-03-05 22:43 ` J. Bruce Fields
[not found] ` <20120305224334.GB16444-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-03-09 22:21 ` J. Bruce Fields
2012-03-09 22:29 ` [PATCH 1/7] " J. Bruce Fields
2012-03-09 22:29 ` [PATCH 2/7] locks: introduce new FL_DELEG lock flag J. Bruce Fields
2012-03-09 22:29 ` [PATCH 3/7] locks: implement delegations J. Bruce Fields
[not found] ` <20120309222114.GA22423-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-03-09 22:29 ` [PATCH 4/7] locks: break delegations on unlink J. Bruce Fields
2012-03-09 22:29 ` [PATCH 5/7] locks: break delegations on rename J. Bruce Fields
2012-03-09 22:29 ` J. Bruce Fields [this message]
2012-03-09 22:29 ` [PATCH 7/7] locks: break delegations on any attribute modification J. Bruce Fields
2012-03-20 19:27 ` [PATCH] vfs: take i_mutex on renamed file J. Bruce Fields
2012-04-10 13:07 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331332174-22621-6-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).