From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: Matthieu CASTET <matthieu.castet@parrot.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] UBI: allow atomic updates to sychronously erase old PEB
Date: Fri, 30 Mar 2012 15:28:23 +0300 [thread overview]
Message-ID: <1333110503.5440.24.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203301413080.10066@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Fri, 2012-03-30 at 14:20 +0200, Joel Reardon wrote:
> Hey,
>
> If there's a power cut after the new version is written and the old one is
> erased, then it is my understanding that while remounting UBI will detect
> that the old version is not needed and put it on the erase queue.
Yes.
> The
> higher layer that issued the call to update the block will have to do a
> blocking clear of the ubi erase queue when remounting after unsafely
> unmounting.
Yes. You can do this if the security is enabled, I think, using
'ubi_sync()'.
I did not have time to look at your patches, but one quick comment is
that we usually call the argument which controls whether the function
has to wait for the operation to complete or not 'sync', could you
please follow this unwritten convention as well?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-30 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 14:55 [PATCH] UBI: allow atomic updates to sychronously erase old PEB Joel Reardon
2012-03-29 16:24 ` Matthieu CASTET
2012-03-30 12:20 ` Joel Reardon
2012-03-30 12:28 ` Artem Bityutskiy [this message]
2012-03-30 12:33 ` Joel Reardon
2012-03-30 12:42 ` Artem Bityutskiy
2012-03-30 15:11 ` Joel Reardon
2012-04-11 12:26 ` Artem Bityutskiy
2012-04-11 13:14 ` Joel Reardon
2012-04-11 16:04 ` Artem Bityutskiy
2012-04-11 13:14 ` [PATCH] UBIFS: use ubi's new ubi_leb_change sync parameter Joel Reardon
2012-04-11 15:38 ` Joel Reardon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333110503.5440.24.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).