linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Zach Brown <zab@zabbo.net>,
	Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: [RFC PATCH v2 00/21] loop: Issue O_DIRECT aio using bio_vec
Date: Fri, 30 Mar 2012 10:43:27 -0500	[thread overview]
Message-ID: <1333122228-13633-1-git-send-email-dave.kleikamp@oracle.com> (raw)

I apologize for sending this out so close to the start of the LSF-MM
Summit. I've been trying to get some performance numbers worthy of
sharing, but other work has been getting in the way. Those will follow,
but I wanted everyone to get a chance to see the current state of the
patchset.

This patchset was begun by Zach Brown and was originally submitted for
review in October, 2009. Feedback was positive, and I have picked up
where he left off, porting his patches to 3.3 and adding support more
file systems.

http://www.spinics.net/lists/linux-fsdevel/msg27514.html

This patch series adds a kernel interface to fs/aio.c so that kernel code can
issue concurrent asynchronous IO to file systems.  It adds an aio command and
file system methods which specify io memory with pages instead of userspace
addresses.

This series was written to reduce the current overhead loop imposes by
performing synchronus buffered file system IO from a kernel thread.  These
patches turn loop into a light weight layer that translates bios into iocbs.

The downside of this is that in its current implementation, performance takes
a big hit for non-synchonous I/O, since the underlying page cache is bypassed.
The tradeoff is that all writes to the loop device make it to the underlying
media, making loop-mounted file systems recoverable.

Changes since version 1:

The biggest change since my first posting is that I took Christoph Hellwig's
advice and changed the direct_IO interface to use struct iov_iter, instead
of duplicating code to handle both struct iovec and struct biovec separately.
This really simplified the patchset, and made support for more filesystems
trivial.

I also reworked the nfs patch to coalesce the bvec pages into larger I/Os,
and fixed a major oversight in btrfs.


Dave Kleikamp (7):
  fuse: convert fuse to use iov_iter_copy_[to|from]_user
  dio: Convert direct_IO to use iov_iter
  dio: add bio_vec support to __blockdev_direct_IO()
  ext4: add support for read_iter and write_iter
  nfs: add support for read_iter, write_iter
  btrfs: add support for read_iter and write_iter
  fs: add read_iter and write_iter to more file systems

Zach Brown (14):
  iov_iter: move into its own file
  iov_iter: add copy_to_user support
  iov_iter: hide iovec details behind ops function pointers
  iov_iter: add bvec support
  iov_iter: add a shorten call
  iov_iter: let callers extract iovecs and bio_vecs
  dio: create a dio_aligned() helper function
  fs: pull iov_iter use higher up the stack
  aio: add aio_kernel_() interface
  aio: add aio support for iov_iter arguments
  bio: add bvec_length(), like iov_length()
  loop: use aio to perform io on the underlying file
  ext3: add support for .read_iter and .write_iter
  ocfs2: add support for read_iter, write_iter, and direct_IO_bvec

 Documentation/filesystems/Locking |    4 +-
 Documentation/filesystems/vfs.txt |    4 +-
 drivers/block/loop.c              |   55 ++++-
 fs/9p/vfs_addr.c                  |    8 +-
 fs/9p/vfs_file.c                  |    4 +
 fs/aio.c                          |  156 +++++++++++++
 fs/block_dev.c                    |    8 +-
 fs/btrfs/file.c                   |   55 +++--
 fs/btrfs/inode.c                  |   70 +++---
 fs/ceph/addr.c                    |    3 +-
 fs/direct-io.c                    |  253 ++++++++++++++-------
 fs/ext2/file.c                    |    2 +
 fs/ext2/inode.c                   |    8 +-
 fs/ext3/file.c                    |    2 +
 fs/ext3/inode.c                   |   15 +-
 fs/ext4/ext4.h                    |    3 +-
 fs/ext4/file.c                    |    2 +
 fs/ext4/indirect.c                |   16 +-
 fs/ext4/inode.c                   |   23 +-
 fs/fat/file.c                     |    2 +
 fs/fat/inode.c                    |   10 +-
 fs/fuse/file.c                    |   29 +--
 fs/gfs2/aops.c                    |    7 +-
 fs/hfs/inode.c                    |    9 +-
 fs/hfsplus/inode.c                |    8 +-
 fs/jfs/file.c                     |    2 +
 fs/jfs/inode.c                    |    7 +-
 fs/nfs/direct.c                   |  454 +++++++++++++++++++++++++++----------
 fs/nfs/file.c                     |   51 +++--
 fs/nilfs2/file.c                  |    2 +
 fs/nilfs2/inode.c                 |    8 +-
 fs/ocfs2/aops.c                   |    8 +-
 fs/ocfs2/file.c                   |   82 +++++--
 fs/ocfs2/ocfs2_trace.h            |    6 +-
 fs/reiserfs/file.c                |    2 +
 fs/reiserfs/inode.c               |    7 +-
 fs/xfs/xfs_aops.c                 |   11 +-
 include/linux/aio.h               |   14 ++
 include/linux/aio_abi.h           |    2 +
 include/linux/bio.h               |    8 +
 include/linux/fs.h                |  131 +++++++++--
 include/linux/loop.h              |    1 +
 include/linux/nfs_fs.h            |    9 +-
 mm/Makefile                       |    2 +-
 mm/filemap.c                      |  388 +++++++++++++------------------
 mm/iov-iter.c                     |  377 ++++++++++++++++++++++++++++++
 46 files changed, 1677 insertions(+), 651 deletions(-)
 create mode 100644 mm/iov-iter.c

-- 
1.7.9.5


             reply	other threads:[~2012-03-30 15:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 15:43 Dave Kleikamp [this message]
2012-03-30 15:43 ` [RFC PATCH v2 01/21] iov_iter: move into its own file Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 02/21] iov_iter: add copy_to_user support Dave Kleikamp
     [not found] ` <1333122228-13633-1-git-send-email-dave.kleikamp-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2012-03-30 15:43   ` [RFC PATCH v2 03/21] fuse: convert fuse to use iov_iter_copy_[to|from]_user Dave Kleikamp
2012-03-30 15:43   ` [RFC PATCH v2 19/21] nfs: add support for read_iter, write_iter Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 04/21] iov_iter: hide iovec details behind ops function pointers Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 05/21] iov_iter: add bvec support Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 06/21] iov_iter: add a shorten call Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 07/21] iov_iter: let callers extract iovecs and bio_vecs Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 08/21] dio: create a dio_aligned() helper function Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 09/21] dio: Convert direct_IO to use iov_iter Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 10/21] dio: add bio_vec support to __blockdev_direct_IO() Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 11/21] fs: pull iov_iter use higher up the stack Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 12/21] aio: add aio_kernel_() interface Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 13/21] aio: add aio support for iov_iter arguments Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 14/21] bio: add bvec_length(), like iov_length() Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 15/21] loop: use aio to perform io on the underlying file Dave Kleikamp
2012-04-20 14:48   ` Maxim V. Patlasov
2012-04-20 15:09     ` Dave Kleikamp
2012-04-20 15:20       ` Jeff Moyer
2012-04-20 15:52         ` Zach Brown
2012-04-20 15:57           ` Dave Kleikamp
2012-04-20 16:14             ` Maxim V. Patlasov
2012-04-20 17:19               ` Dave Kleikamp
2012-04-20 17:37                 ` Maxim V. Patlasov
2012-04-20 16:35           ` Jeff Moyer
2012-04-20 17:48             ` Zach Brown
2012-04-20 16:14         ` Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 16/21] ext3: add support for .read_iter and .write_iter Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 17/21] ocfs2: add support for read_iter, write_iter, and direct_IO_bvec Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 18/21] ext4: add support for read_iter and write_iter Dave Kleikamp
2012-04-02 18:42   ` Ted Ts'o
2012-04-02 22:45     ` Dave Kleikamp
2012-04-03  0:11       ` Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 20/21] btrfs: " Dave Kleikamp
2012-03-30 15:43 ` [RFC PATCH v2 21/21] fs: add read_iter and write_iter to more file systems Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333122228-13633-1-git-send-email-dave.kleikamp@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).