From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v2 3/4] fat: mark superblock as dirty less often
Date: Sat, 14 Apr 2012 14:08:18 +0300
Message-ID: <1334401700.2263.26.camel@koala>
References: <1334326795-2446-1-git-send-email-dedekind1@gmail.com>
	 <1334326795-2446-4-git-send-email-dedekind1@gmail.com>
	 <87k41ihdub.fsf@devron.myhome.or.jp> <1334399070.2263.3.camel@koala>
	 <877gxiha4b.fsf@devron.myhome.or.jp>
Reply-To: dedekind1@gmail.com
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-SZPFWEkt1Lsk7HTMORNx"
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
	Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <877gxiha4b.fsf@devron.myhome.or.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org


--=-SZPFWEkt1Lsk7HTMORNx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2012-04-14 at 19:37 +0900, OGAWA Hirofumi wrote:
> > But could you please explain why do we need an extra variable? What is
> > the problem with doing all our FAT table changes and then marking the
> > FSINFO as dirty?
>=20
> Above example may not be proper. I meant please dirty FSINFO only if
> necessary. Your patch seems to be dirty even if code didn't change
> FSINFO.

Ah, yes, in 'fat_alloc_clusters()' indeed, thanks, I'll fix this.

--=20
Best Regards,
Artem Bityutskiy

--=-SZPFWEkt1Lsk7HTMORNx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAABAgAGBQJPiVqiAAoJEJtuLFy+q7fesukIALdjHAPcMDL+wUKLsUbMfqoA
utuKtqNx4zxOvN83MRYvlr1D2vowpU5cQILsA03DEbFtS8iMb44l9tP6BWIAcrXg
s7fSDv9GJeYZu9cARnmbuogTlIzV5cv3Jt/6avbOYh/ey/+g3FKu6f/jiWvaK2ly
3q9Oji985djfEHrr2r46KrChDuStvhPECR9n+M4DCQIrcIm/TRnFd6QVWKhnOll6
oZlKPQ5VXOpyI64NG88exDb2wBSVkyNu9HYQg4ozJSSTxVqniBqEB2WUxenS2HJT
nUhZXQla8EdZ7ZcTuHQ9mZLGMv57DZ+bLZ56N+xiKxptw60O6ObcxFUeMRkTSBM=
=p/0H
-----END PGP SIGNATURE-----

--=-SZPFWEkt1Lsk7HTMORNx--