[PATCH] fs: remove 8 bytes of padding from struct writeback_control on 64 bit builds

[PATCH] fs: remove 8 bytes of padding from struct writeback_control on 64 bit builds

[Richard Kennedy]

Reorder structure writeback_control to remove 8 bytes of padding on 64
bit builds, this shrinks its size from 48 to 40 bytes.

This structure is always on the stack and uses C99 named initialisation,
so should be safe and have a small impact on stack usage.
    
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>

--

patch against v3.4-rc4
compiled and tested on x86_64

I've been running my desktop with this patch applied for several days
and have not seen any problems.
regards
Richard





diff --git a/include/linux/writeback.h b/include/linux/writeback.h
index a2b84f5..3309736 100644
--- a/include/linux/writeback.h
+++ b/include/linux/writeback.h
@@ -58,7 +58,6 @@ extern const char *wb_reason_name[];
  * in a manner such that unspecified fields are set to zero.
  */
 struct writeback_control {
-	enum writeback_sync_modes sync_mode;
 	long nr_to_write;		/* Write this many pages, and decrement
 					   this for each page written */
 	long pages_skipped;		/* Pages which were not written */
@@ -71,6 +70,8 @@ struct writeback_control {
 	loff_t range_start;
 	loff_t range_end;
 
+	enum writeback_sync_modes sync_mode;
+
 	unsigned for_kupdate:1;		/* A kupdate writeback */
 	unsigned for_background:1;	/* A background writeback */
 	unsigned tagged_writepages:1;	/* tag-and-write to avoid livelock */

Re: [PATCH] fs: remove 8 bytes of padding from struct writeback_control on 64 bit builds

[Fengguang Wu]

On Wed, Apr 25, 2012 at 02:53:05PM +0100, Richard Kennedy wrote:
> Reorder structure writeback_control to remove 8 bytes of padding on 64
> bit builds, this shrinks its size from 48 to 40 bytes.
> 
> This structure is always on the stack and uses C99 named initialisation,
> so should be safe and have a small impact on stack usage.
>     
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
> 
> --
> 
> patch against v3.4-rc4
> compiled and tested on x86_64
> 
> I've been running my desktop with this patch applied for several days
> and have not seen any problems.
> regards
> Richard

Applied, thanks!

Fengguang