From: bfields@fieldses.org
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 3/5] vfs: don't use PARENT/CHILD lock classes for non-directories
Date: Wed, 25 Apr 2012 11:22:07 -0400 [thread overview]
Message-ID: <1335367329-929-3-git-send-email-bfields@fieldses.org> (raw)
In-Reply-To: <20120418215238.GA11959@fieldses.org>
From: "J. Bruce Fields" <bfields@redhat.com>
Reserve I_MUTEX_PARENT and I_MUTEX_CHILD for locking of actual
directories.
(Since I_MUTEX_QUOTA is now used just any time we need to lock a second
non-directory object, not necessarily a quota file, perhaps it should
get some more generic name, like I_MUTEX_NONDIR2.)
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/inode.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 9718f1c..487c924 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -971,12 +971,12 @@ void lock_two_nondirectories(struct inode *inode1, struct inode *inode2)
if (inode1 == inode2 || inode2 == NULL)
mutex_lock(&inode1->i_mutex);
else if (inode1 < inode2) {
- mutex_lock_nested(&inode1->i_mutex, I_MUTEX_PARENT);
- mutex_lock_nested(&inode2->i_mutex, I_MUTEX_CHILD);
+ mutex_lock(&inode1->i_mutex);
+ mutex_lock_nested(&inode2->i_mutex, I_MUTEX_QUOTA);
} else {
- mutex_lock_nested(&inode2->i_mutex, I_MUTEX_PARENT);
- mutex_lock_nested(&inode1->i_mutex, I_MUTEX_CHILD);
+ mutex_lock(&inode2->i_mutex);
+ mutex_lock_nested(&inode1->i_mutex, I_MUTEX_QUOTA);
}
}
EXPORT_SYMBOL(lock_two_nondirectories);
--
1.7.5.4
next prev parent reply other threads:[~2012-04-25 15:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 5:25 [git pull] vfs and fs fixes Al Viro
2012-04-17 15:01 ` Linus Torvalds
2012-04-17 16:22 ` J. Bruce Fields
2012-04-17 16:33 ` Linus Torvalds
2012-04-17 17:06 ` J. Bruce Fields
2012-04-17 17:59 ` Al Viro
2012-04-17 18:01 ` Al Viro
2012-04-17 18:28 ` Al Viro
2012-04-17 21:14 ` J. Bruce Fields
2012-04-17 22:08 ` Linus Torvalds
2012-04-17 23:44 ` Al Viro
2012-04-18 0:49 ` J. Bruce Fields
2012-04-18 0:56 ` Linus Torvalds
2012-04-18 21:52 ` J. Bruce Fields
2012-04-25 15:20 ` J. Bruce Fields
2012-04-25 15:22 ` [PATCH 1/5] vfs: fix outdated i_mutex_lock_class documentation bfields
2012-04-25 15:22 ` [PATCH 2/5] vfs: pull ext4's double-i_mutex-locking into common code bfields
2012-04-25 15:22 ` bfields [this message]
2012-04-25 15:22 ` [PATCH 4/5] vfs: take i_mutex on renamed file bfields
2012-04-25 15:22 ` [PATCH 5/5] vfs: change nondirectory i_mutex ordering to fix quota deadlock bfields
2012-04-25 15:28 ` J. Bruce Fields
2012-04-25 19:53 ` Jan Kara
2012-04-25 19:58 ` J. Bruce Fields
2012-04-20 11:15 ` [git pull] vfs and fs fixes Jan Kara
2012-04-24 19:52 ` J. Bruce Fields
2012-04-24 22:23 ` Jan Kara
2012-04-25 11:29 ` J. Bruce Fields
2012-04-25 16:26 ` Jan Kara
2012-04-25 16:47 ` Steven Whitehouse
2012-04-25 17:11 ` J. Bruce Fields
2012-04-18 0:47 ` J. Bruce Fields
2012-04-19 3:23 ` Benjamin Herrenschmidt
2012-04-19 14:50 ` Ted Ts'o
2012-04-24 17:40 ` Greg KH
2012-04-24 17:45 ` Al Viro
2012-04-24 17:59 ` Greg KH
2012-04-24 18:04 ` Al Viro
2012-04-24 20:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335367329-929-3-git-send-email-bfields@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).