From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>, Andy Whitcroft <apw@canonical.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
mszeredi@suse.cz, Sedat Dilek <sedat.dilek@gmail.com>
Subject: [PATCH 4/5] overlayfs: switch from d_alloc_root() to d_make_root()
Date: Tue, 1 May 2012 16:17:54 +0100 [thread overview]
Message-ID: <1335885475-11990-5-git-send-email-apw@canonical.com> (raw)
In-Reply-To: <1335885475-11990-1-git-send-email-apw@canonical.com>
d_alloc_root() has been deprecated (and removed) in favour of
d_make_root(). Follow this new interface.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
fs/overlayfs/super.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index b679019..24bdcc5 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -538,13 +538,9 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
if (oe == NULL)
goto out_free_config;
- root_inode = ovl_new_inode(sb, S_IFDIR, oe);
- if (!root_inode)
- goto out_free_oe;
-
err = kern_path(ufs->config.upperdir, LOOKUP_FOLLOW, &upperpath);
if (err)
- goto out_put_root;
+ goto out_free_oe;
err = kern_path(ufs->config.lowerdir, LOOKUP_FOLLOW, &lowerpath);
if (err)
@@ -596,7 +592,11 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
}
err = -ENOMEM;
- root_dentry = d_alloc_root(root_inode);
+ root_inode = ovl_new_inode(sb, S_IFDIR, oe);
+ if (!root_inode)
+ goto out_drop_write;
+
+ root_dentry = d_make_root(root_inode);
if (!root_dentry)
goto out_drop_write;
@@ -626,8 +626,6 @@ out_put_lowerpath:
path_put(&lowerpath);
out_put_upperpath:
path_put(&upperpath);
-out_put_root:
- iput(root_inode);
out_free_oe:
kfree(oe);
out_free_config:
--
1.7.9.5
next prev parent reply other threads:[~2012-05-01 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 15:17 [PATCH 0/5] overlayfs v3.4-rc5 updates Andy Whitcroft
2012-05-01 15:17 ` [PATCH 1/5] inode_only_permission: export inode level permissions checks Andy Whitcroft
2012-05-01 15:17 ` [PATCH 2/5] overlayfs: switch to use inode_only_permissions Andy Whitcroft
2012-05-01 15:17 ` [PATCH 3/5] overlayfs: follow header cleanup Andy Whitcroft
2012-05-01 15:17 ` Andy Whitcroft [this message]
2012-05-01 15:17 ` [PATCH 5/5] overlayfs: update touch_atime() usage Andy Whitcroft
2012-05-14 11:20 ` [PATCH 0/5] overlayfs v3.4-rc5 updates Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335885475-11990-5-git-send-email-apw@canonical.com \
--to=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@suse.cz \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).