From: Jeff Layton <jlayton@redhat.com>
To: viro@ZenIV.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, miklos@szeredi.hu,
hch@infradead.org, michael.brantley@deshaw.com
Subject: [PATCH v1 RESEND 02/12] vfs: make fstatat retry on ESTALE errors from getattr call
Date: Mon, 7 May 2012 10:12:01 -0400 [thread overview]
Message-ID: <1336399931-20234-3-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1336399931-20234-1-git-send-email-jlayton@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/stat.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/stat.c b/fs/stat.c
index c733dc5..f3eef0d 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -73,7 +73,8 @@ int vfs_fstatat(int dfd, const char __user *filename, struct kstat *stat,
{
struct path path;
int error = -EINVAL;
- int lookup_flags = 0;
+ unsigned int try = 0;
+ unsigned int lookup_flags = 0;
if ((flag & ~(AT_SYMLINK_NOFOLLOW | AT_NO_AUTOMOUNT |
AT_EMPTY_PATH)) != 0)
@@ -84,12 +85,15 @@ int vfs_fstatat(int dfd, const char __user *filename, struct kstat *stat,
if (flag & AT_EMPTY_PATH)
lookup_flags |= LOOKUP_EMPTY;
- error = user_path_at(dfd, filename, lookup_flags, &path);
- if (error)
- goto out;
+ do {
+ error = user_path_at(dfd, filename, lookup_flags, &path);
+ if (error)
+ break;
- error = vfs_getattr(path.mnt, path.dentry, stat);
- path_put(&path);
+ error = vfs_getattr(path.mnt, path.dentry, stat);
+ path_put(&path);
+ lookup_flags |= LOOKUP_REVAL;
+ } while (retry_estale(error, try++));
out:
return error;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-05-07 14:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 14:11 [PATCH v1 RESEND 00/12] vfs: add the ability to retry on ESTALE to several syscalls Jeff Layton
2012-05-07 14:12 ` Jeff Layton [this message]
2012-05-07 14:12 ` [PATCH v1 RESEND 03/12] vfs: fix readlinkat to retry on ESTALE Jeff Layton
[not found] ` <1336399931-20234-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-07 14:12 ` [PATCH v1 RESEND 01/12] vfs: add a retry_estale helper function to handle retries " Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 04/12] vfs: add new "reval" argument to kern_path_create and user_path_create Jeff Layton
2012-05-09 10:57 ` Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 05/12] vfs: fix mknodat to retry on ESTALE errors Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 06/12] vfs: fix mkdir " Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 12/12] vfs: fix renameat " Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 07/12] vfs: add a "reval" flag to args for user_path_parent Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 08/12] vfs: make rmdir retry on ESTALE errors Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 09/12] vfs: make do_unlinkat " Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 10/12] vfs: fix symlinkat to " Jeff Layton
2012-05-07 14:12 ` [PATCH v1 RESEND 11/12] vfs: fix linkat " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336399931-20234-3-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=michael.brantley@deshaw.com \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).