linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/7] affs: remove useless superblock writeout on remount
Date: Tue,  5 Jun 2012 14:28:11 +0300	[thread overview]
Message-ID: <1338895695-10362-4-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1338895695-10362-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

We do not need to write out the superblock from '->remount_fs()' because
VFS has already called '->sync_fs()' by this time and the superblock has
already been written out. Thus, remove the 'affs_write_super()'
infocation from 'affs_remount()'.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/affs/super.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/affs/super.c b/fs/affs/super.c
index db184c0..3fc50b1 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -546,10 +546,9 @@ affs_remount(struct super_block *sb, int *flags, char *data)
 	if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY))
 		return 0;
 
-	if (*flags & MS_RDONLY) {
-		affs_write_super(sb);
+	if (*flags & MS_RDONLY)
 		affs_free_bitmap(sb);
-	} else
+	else
 		res = affs_init_bitmap(sb, flags);
 
 	return res;
-- 
1.7.7.6

  parent reply	other threads:[~2012-06-05 11:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 11:28 [PATCH 0/7] affs: stop using write_supers and s_dirt Artem Bityutskiy
2012-06-05 11:28 ` [PATCH 1/7] affs: remove strange argument of affs_commit_super Artem Bityutskiy
2012-06-06 10:29   ` Jan Kara
2012-06-05 11:28 ` [PATCH 2/7] affs: remove useless superblock writeout on unmount Artem Bityutskiy
2012-06-05 11:28 ` Artem Bityutskiy [this message]
2012-06-05 11:28 ` [PATCH 4/7] affs: re-structure superblock locking a bit Artem Bityutskiy
2012-06-05 11:28 ` [PATCH 5/7] affs: stop using lock_super Artem Bityutskiy
2012-06-06 10:07   ` Jan Kara
2012-06-06 16:00     ` Artem Bityutskiy
2012-06-05 11:28 ` [PATCH 6/7] affs: introduce VFS superblock object back-reference Artem Bityutskiy
2012-06-05 11:28 ` [PATCH 7/7] affs: get rid of affs_sync_super Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338895695-10362-4-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).