linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/7] affs: remove useless superblock writeout on unmount
Date: Wed,  6 Jun 2012 18:56:52 +0300	[thread overview]
Message-ID: <1338998217-5010-3-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1338998217-5010-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

We do not need to write out the superblock from '->put_super()' because VFS has
already called '->sync_fs()' by this time and the superblock has already been
written out. Thus, remove the 'affs_commit_super()' infocation from
'affs_put_super()'.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/affs/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/affs/super.c b/fs/affs/super.c
index 1d42e46..12b4f58 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -44,9 +44,6 @@ affs_put_super(struct super_block *sb)
 	struct affs_sb_info *sbi = AFFS_SB(sb);
 	pr_debug("AFFS: put_super()\n");
 
-	if (!(sb->s_flags & MS_RDONLY) && sb->s_dirt)
-		affs_commit_super(sb, 1);
-
 	kfree(sbi->s_prefix);
 	affs_free_bitmap(sb);
 	affs_brelse(sbi->s_root_bh);
-- 
1.7.7.6

  parent reply	other threads:[~2012-06-06 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 15:56 [PATCH v2 0/7] affs: stop using write_supers and s_dirt Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 1/7] affs: stop setting bm_flags Artem Bityutskiy
2012-06-16 18:49   ` Geert Uytterhoeven
2012-06-27  9:18     ` Artem Bityutskiy
2012-06-06 15:56 ` Artem Bityutskiy [this message]
2012-06-06 15:56 ` [PATCH v2 3/7] affs: remove useless superblock writeout on remount Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 4/7] affs: re-structure superblock locking a bit Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 5/7] affs: stop using lock_super Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 6/7] affs: introduce VFS superblock object back-reference Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 7/7] affs: get rid of affs_sync_super Artem Bityutskiy
2012-07-02 14:06   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338998217-5010-3-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).