From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: [PATCH v2 3/7] affs: remove useless superblock writeout on remount Date: Wed, 6 Jun 2012 18:56:53 +0300 Message-ID: <1338998217-5010-4-git-send-email-dedekind1@gmail.com> References: <1338998217-5010-1-git-send-email-dedekind1@gmail.com> Cc: Linux FS Maling List , Linux Kernel Maling List To: Al Viro , Jan Kara Return-path: In-Reply-To: <1338998217-5010-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Artem Bityutskiy We do not need to write out the superblock from '->remount_fs()' because VFS has already called '->sync_fs()' by this time and the superblock has already been written out. Thus, remove the 'affs_write_super()' infocation from 'affs_remount()'. Signed-off-by: Artem Bityutskiy --- fs/affs/super.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/affs/super.c b/fs/affs/super.c index 12b4f58..c837e43 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c @@ -545,10 +545,9 @@ affs_remount(struct super_block *sb, int *flags, char *data) if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) return 0; - if (*flags & MS_RDONLY) { - affs_write_super(sb); + if (*flags & MS_RDONLY) affs_free_bitmap(sb); - } else + else res = affs_init_bitmap(sb, flags); return res; -- 1.7.7.6