From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 4/7] affs: re-structure superblock locking a bit
Date: Wed, 6 Jun 2012 18:56:54 +0300 [thread overview]
Message-ID: <1338998217-5010-5-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1338998217-5010-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
AFFS wants to serialize the superblock (the root block in AFFS terms) updates
and uses 'lock_super()/unlock_super()' for these purposes. This patch pushes the
locking down to the 'affs_commit_super()' from the callers.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
fs/affs/super.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/affs/super.c b/fs/affs/super.c
index c837e43..4ceec56 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -31,11 +31,13 @@ affs_commit_super(struct super_block *sb, int wait)
struct buffer_head *bh = sbi->s_root_bh;
struct affs_root_tail *tail = AFFS_ROOT_TAIL(sb, bh);
+ lock_super(sb);
secs_to_datestamp(get_seconds(), &tail->disk_change);
affs_fix_checksum(sb, bh);
mark_buffer_dirty(bh);
if (wait)
sync_dirty_buffer(bh);
+ unlock_super(sb);
}
static void
@@ -54,22 +56,17 @@ affs_put_super(struct super_block *sb)
static void
affs_write_super(struct super_block *sb)
{
- lock_super(sb);
if (!(sb->s_flags & MS_RDONLY))
affs_commit_super(sb, 1);
sb->s_dirt = 0;
- unlock_super(sb);
-
pr_debug("AFFS: write_super() at %lu, clean=2\n", get_seconds());
}
static int
affs_sync_fs(struct super_block *sb, int wait)
{
- lock_super(sb);
affs_commit_super(sb, wait);
sb->s_dirt = 0;
- unlock_super(sb);
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-06-06 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 15:56 [PATCH v2 0/7] affs: stop using write_supers and s_dirt Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 1/7] affs: stop setting bm_flags Artem Bityutskiy
2012-06-16 18:49 ` Geert Uytterhoeven
2012-06-27 9:18 ` Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 2/7] affs: remove useless superblock writeout on unmount Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 3/7] affs: remove useless superblock writeout on remount Artem Bityutskiy
2012-06-06 15:56 ` Artem Bityutskiy [this message]
2012-06-06 15:56 ` [PATCH v2 5/7] affs: stop using lock_super Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 6/7] affs: introduce VFS superblock object back-reference Artem Bityutskiy
2012-06-06 15:56 ` [PATCH v2 7/7] affs: get rid of affs_sync_super Artem Bityutskiy
2012-07-02 14:06 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338998217-5010-5-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).