From: Artem Bityutskiy <dedekind1@gmail.com>
To: Saugata Das <saugata.das@stericsson.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mmc@vger.kernel.org, patches@linaro.org, venkat@linaro.org,
Saugata Das <saugata.das@linaro.org>
Subject: Re: [PATCH 2/3] ext4: Context support
Date: Mon, 11 Jun 2012 14:41:31 +0300 [thread overview]
Message-ID: <1339414891.2401.12.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1339411562-17100-2-git-send-email-saugata.das@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Mon, 2012-06-11 at 16:16 +0530, Saugata Das wrote:
> +/* Get the context of the buffer within the underlying storage device */
> +static int ext4_get_context(struct page *page)
> +{
> + if (page && page->mapping && page->mapping->host)
> + return page->mapping->host->i_ino;
> + else
> + return 0;
> +}
Word "context" is very generic and it is widely used various things, and
I believe we should try to avoid overloading this term and obfuscating
the I/O stack with various functions and other identifiers like
"get_context()". This would hurt readability. It is fine to use it
withing the UFS-specific code, but not globally withing the kernel code.
I do not really have good name candidates, but even "ufscontext" is
already better than just "context". Or "iocontext" ? Or just "ufsdata" ?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-11 11:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 10:46 [PATCH 1/3] block: Context support Saugata Das
2012-06-11 10:46 ` [PATCH 2/3] ext4: " Saugata Das
2012-06-11 11:41 ` Artem Bityutskiy [this message]
2012-06-11 12:27 ` Ted Ts'o
2012-06-12 12:21 ` Saugata Das
2012-06-12 12:32 ` Ted Ts'o
2012-06-12 13:29 ` Arnd Bergmann
2012-06-12 14:26 ` Saugata Das
2012-06-12 14:55 ` Arnd Bergmann
2012-06-12 18:19 ` Ted Ts'o
2012-06-12 20:07 ` Arnd Bergmann
2012-06-12 20:41 ` Ted Ts'o
2012-06-13 19:44 ` Arnd Bergmann
2012-06-13 20:00 ` Ted Ts'o
2012-06-13 20:43 ` Arnd Bergmann
2012-06-14 2:07 ` Ted Ts'o
2012-06-14 16:14 ` Nicolas Pitre
2012-06-14 16:24 ` Artem Bityutskiy
2012-06-14 17:05 ` Ted Ts'o
2012-06-14 19:08 ` Nicolas Pitre
2012-06-15 9:19 ` Arnd Bergmann
2012-06-15 21:30 ` Ted Ts'o
2012-06-16 6:49 ` Arnd Bergmann
2012-06-14 21:55 ` Arnd Bergmann
2012-06-15 5:18 ` Andreas Dilger
2012-06-15 9:25 ` Arnd Bergmann
2012-06-15 9:40 ` Andreas Dilger
2012-06-15 10:54 ` Arnd Bergmann
2012-06-15 22:04 ` Ted Ts'o
2012-06-15 22:25 ` Andreas Dilger
2012-06-16 7:14 ` Arnd Bergmann
2012-06-16 7:28 ` Arnd Bergmann
2012-06-16 7:26 ` Arnd Bergmann
2012-06-16 13:49 ` Ted Ts'o
2012-06-16 17:41 ` Arnd Bergmann
2012-06-18 17:42 ` Ted Ts'o
2012-06-19 15:17 ` Arnd Bergmann
2012-06-20 15:09 ` Luca Porzio (lporzio)
2012-06-20 15:46 ` Arnd Bergmann
2012-06-22 13:29 ` Artem Bityutskiy
2012-06-22 14:07 ` Luca Porzio (lporzio)
2012-06-11 10:46 ` [PATCH 3/3] mmc: " Saugata Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339414891.2401.12.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=saugata.das@linaro.org \
--cc=saugata.das@stericsson.com \
--cc=venkat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).