From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/6] hfs: remove extra mdb write on unmount
Date: Tue, 12 Jun 2012 11:13:35 +0300 [thread overview]
Message-ID: <1339488818-14461-4-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1339488818-14461-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
HFS calls 'hfs_write_super()' from 'hfs_put_super()' in order to write the MDB
to the media. However, it is not needed because VFS calls '->sync_fs()' before
calling '->put_super()' - so by the time we are in 'hfs_write_super()', the MDB
is already synchronized.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
fs/hfs/super.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/hfs/super.c b/fs/hfs/super.c
index f7c06bb..47e4119 100644
--- a/fs/hfs/super.c
+++ b/fs/hfs/super.c
@@ -74,8 +74,6 @@ static int hfs_sync_fs(struct super_block *sb, int wait)
*/
static void hfs_put_super(struct super_block *sb)
{
- if (sb->s_dirt)
- hfs_write_super(sb);
hfs_mdb_close(sb);
/* release the MDB's resources */
hfs_mdb_put(sb);
--
1.7.7.6
next prev parent reply other threads:[~2012-06-12 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 8:13 [PATCH 0/6] hfs: stop using write_supers and s_dirt Artem Bityutskiy
2012-06-12 8:13 ` [PATCH 1/6] hfs: push lock_super down Artem Bityutskiy
2012-06-12 8:13 ` [PATCH 2/6] hfs: get rid of lock_super Artem Bityutskiy
2012-06-12 8:13 ` Artem Bityutskiy [this message]
2012-06-12 8:13 ` [PATCH 4/6] hfs: simplify a bit checking for R/O Artem Bityutskiy
2012-06-12 8:13 ` [PATCH 5/6] hfs: introduce VFS superblock object back-reference Artem Bityutskiy
2012-06-12 8:13 ` [PATCH 6/6] hfs: get rid of hfs_sync_super Artem Bityutskiy
2012-07-02 14:15 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339488818-14461-4-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).