From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, tytso@mit.edu,
achender@linux.vnet.ibm.com, Lukas Czerner <lczerner@redhat.com>,
Hugh Dickins <hughd@google.com>
Subject: [PATCH 3/8] shmem: pass LLONG_MAX to shmem_truncate_range
Date: Fri, 29 Jun 2012 12:56:05 +0200 [thread overview]
Message-ID: <1340967370-13728-3-git-send-email-lczerner@redhat.com> (raw)
In-Reply-To: <1340967370-13728-1-git-send-email-lczerner@redhat.com>
Currently we're passing -1 to shmem_truncate_range which can then call
truncate_inode_pages_range() which is actually really confusing since the
argument is signed so we do not get "huge" number as one would expect,
but rather just -1. To make things clearer and easier for
truncate_inode_pages_range() just pass LLONG_MAX since it is actually what
was intended anyway.
It also makes thing easier for allowing truncate_inode_pages_range() to
handle non page aligned regions. Moreover letting the lend argument to
be negative might actually hide some bugs.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
---
mm/shmem.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index a15a466..470ee75 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2960,7 +2960,8 @@ void shmem_unlock_mapping(struct address_space *mapping)
void shmem_truncate_range(struct inode *inode, loff_t lstart, loff_t lend)
{
- truncate_inode_pages_range(inode->i_mapping, lstart, lend);
+ truncate_inode_pages_range(inode->i_mapping, lstart,
+ lend == -1 ? LLONG_MAX : last);
}
EXPORT_SYMBOL_GPL(shmem_truncate_range);
--
1.7.7.6
next prev parent reply other threads:[~2012-06-29 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 10:56 [PATCH 1/8] Revert "ext4: remove no longer used functions in inode.c" Lukas Czerner
2012-06-29 10:56 ` [PATCH 2/8] Revert "ext4: fix fsx truncate failure" Lukas Czerner
2012-06-29 10:56 ` Lukas Czerner [this message]
2012-06-29 10:56 ` [PATCH 4/8] xfs: pass LLONG_MAX to truncate_inode_pages_range Lukas Czerner
2012-06-29 10:56 ` [PATCH 5/8] mm: " Lukas Czerner
2012-06-29 10:56 ` [PATCH 6/8] mm: teach truncate_inode_pages_range() to hadnle non page aligned ranges Lukas Czerner
2012-06-29 10:56 ` [PATCH 7/8] ext4: use ext4_zero_partial_blocks in punch_hole Lukas Czerner
2012-06-29 10:56 ` [PATCH 8/8] ext4: remove unused discard_partial_page_buffers Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340967370-13728-3-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=achender@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).