From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org,
pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org
Subject: [PATCH v3 13/17] vfs: make do_unlinkat retry on ESTALE errors
Date: Fri, 29 Jun 2012 14:57:56 -0400 [thread overview]
Message-ID: <1340996280-27123-14-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1340996280-27123-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/namei.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 7fccc1c..7fadc99 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2955,8 +2955,14 @@ static long do_unlinkat(int dfd, const char __user *pathname)
struct dentry *dentry;
struct nameidata nd;
struct inode *inode = NULL;
+ unsigned int try = 0;
+ unsigned int lookup_flags = LOOKUP_PARENT;
- error = user_path_parent(dfd, pathname, &nd, &name);
+ name = getname(pathname);
+ if (IS_ERR(name))
+ return PTR_ERR(name);
+retry:
+ error = do_path_lookup(dfd, name, lookup_flags, &nd);
if (error)
return error;
@@ -2994,6 +3000,10 @@ exit3:
iput(inode); /* truncate the inode here */
exit1:
path_put(&nd.path);
+ if (retry_estale(error, try++)) {
+ lookup_flags |= LOOKUP_REVAL;
+ goto retry;
+ }
putname(name);
return error;
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-29 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:57 [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls Jeff Layton
2012-06-29 18:57 ` [PATCH v3 01/17] vfs: add a retry_estale helper function to handle retries on ESTALE Jeff Layton
2012-06-29 18:57 ` [PATCH v3 03/17] vfs: make fstatat retry on ESTALE errors from getattr call Jeff Layton
2012-06-29 18:57 ` [PATCH v3 04/17] vfs: fix readlinkat to retry on ESTALE Jeff Layton
[not found] ` <1340996280-27123-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-29 18:57 ` [PATCH v3 02/17] vfs: add a kern_path_at function Jeff Layton
2012-06-29 18:57 ` [PATCH v3 05/17] vfs: remove user_path_at_empty Jeff Layton
2012-06-29 18:57 ` Jeff Layton [this message]
2012-06-29 18:57 ` [PATCH v3 06/17] vfs: turn "empty" arg in getname_flags into a bool Jeff Layton
2012-06-29 18:57 ` [PATCH v3 07/17] vfs: add new "reval" argument to kern_path_create Jeff Layton
2012-06-29 18:57 ` [PATCH v3 08/17] vfs: fix mknodat to retry on ESTALE errors Jeff Layton
2012-06-29 18:57 ` [PATCH v3 09/17] vfs: fix mkdir " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 10/17] vfs: fix symlinkat " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 11/17] vfs: fix linkat " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 12/17] vfs: make rmdir " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 14/17] vfs: fix renameat to " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 15/17] vfs: remove user_path_parent Jeff Layton
2012-06-29 18:57 ` [PATCH v3 16/17] vfs: have do_sys_truncate retry once on an ESTALE error Jeff Layton
2012-06-29 18:58 ` [PATCH v3 17/17] vfs: have faccessat " Jeff Layton
2012-07-11 18:42 ` [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls Steven J. Magnani
[not found] ` <1342032143.2190.22.camel-GF+V7FdoMD4Ycxa7k1C3m3PVXB/TiYYQ@public.gmane.org>
2012-07-11 19:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340996280-27123-14-git-send-email-jlayton@redhat.com \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org \
--cc=miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org \
--cc=pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org \
--cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).