From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 1/3] fs/sysv: remove useless write_super call
Date: Tue, 3 Jul 2012 16:43:26 +0300 [thread overview]
Message-ID: <1341323008-29414-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1341323008-29414-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
We do not need to call 'sysv_write_super()' from 'sysv_put_super()',
because VFS has called 'sysv_sync_fs()' before calling '->put_super()'.
So remove it.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
fs/sysv/inode.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index 08d0b25..af13d13 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -81,9 +81,6 @@ static void sysv_put_super(struct super_block *sb)
{
struct sysv_sb_info *sbi = SYSV_SB(sb);
- if (sb->s_dirt)
- sysv_write_super(sb);
-
if (!(sb->s_flags & MS_RDONLY)) {
/* XXX ext2 also updates the state here */
mark_buffer_dirty(sbi->s_bh1);
--
1.7.7.6
next prev parent reply other threads:[~2012-07-03 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:43 [PATCH 0/3] fs/sysv: stop using write_supers and s_dirt Artem Bityutskiy
2012-07-03 13:43 ` Artem Bityutskiy [this message]
2012-07-03 13:43 ` [PATCH 2/3] fs/sysv: remove another useless write_super call Artem Bityutskiy
2012-07-03 13:43 ` [PATCH 3/3] fs/sysv: stop using write_super and s_dirt Artem Bityutskiy
2012-07-03 14:13 ` Alan Cox
2012-07-03 14:44 ` Artem Bityutskiy
2012-07-12 14:37 ` [PATCH 0/3] fs/sysv: stop using write_supers " Artem Bityutskiy
2012-07-12 14:49 ` Artem Bityutskiy
2012-07-13 21:42 ` Andrew Morton
2012-07-14 4:04 ` Artem Bityutskiy
2012-07-17 15:13 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341323008-29414-2-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).