From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: [PATCH 2/3] fs/sysv: remove another useless write_super call Date: Tue, 3 Jul 2012 16:43:27 +0300 Message-ID: <1341323008-29414-3-git-send-email-dedekind1@gmail.com> References: <1341323008-29414-1-git-send-email-dedekind1@gmail.com> Cc: Linux Kernel Maling List , Linux FS Maling List To: Andrew Morton , Al Viro Return-path: In-Reply-To: <1341323008-29414-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Artem Bityutskiy We do not need to call 'sysv_write_super()' from 'sysv_remount()', because VFS has called 'sysv_sync_fs()' before calling '->remount()'. So remove it. Remove also '(un)lock_super()' which obvioulsy is becoming useless in this function. Signed-off-by: Artem Bityutskiy --- fs/sysv/inode.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index af13d13..f20ffe3 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -68,12 +68,9 @@ static void sysv_write_super(struct super_block *sb) static int sysv_remount(struct super_block *sb, int *flags, char *data) { struct sysv_sb_info *sbi = SYSV_SB(sb); - lock_super(sb); + if (sbi->s_forced_ro) *flags |= MS_RDONLY; - if (*flags & MS_RDONLY) - sysv_write_super(sb); - unlock_super(sb); return 0; } -- 1.7.7.6