From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Evgeniy Dushistov <dushistov@mail.ru>
Cc: Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] fs/ufs: remove extra superblock write on unmount
Date: Thu, 12 Jul 2012 16:28:06 +0300 [thread overview]
Message-ID: <1342099688-14894-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1342099688-14894-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
UFS calls 'ufs_write_super()' from 'ufs_put_super()' in order to write the
superblocks to the media. However, it is not needed because VFS calls
'->sync_fs()' before calling '->put_super()' - so by the time we are in
'ufs_write_super()', the superblocks are already synchronized.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
fs/ufs/super.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/ufs/super.c b/fs/ufs/super.c
index 302f340..ae91e0a 100644
--- a/fs/ufs/super.c
+++ b/fs/ufs/super.c
@@ -1238,9 +1238,6 @@ static void ufs_put_super(struct super_block *sb)
UFSD("ENTER\n");
- if (sb->s_dirt)
- ufs_write_super(sb);
-
if (!(sb->s_flags & MS_RDONLY))
ufs_put_super_internal(sb);
--
1.7.7.6
next prev parent reply other threads:[~2012-07-12 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 13:28 [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Artem Bityutskiy
2012-07-12 13:28 ` Artem Bityutskiy [this message]
2012-07-12 13:28 ` [PATCH 2/3] fs/ufs: re-arrange the code a bit Artem Bityutskiy
2012-07-12 13:28 ` [PATCH 3/3] fs/ufs: get rid of write_super Artem Bityutskiy
2012-07-12 22:58 ` [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Andrew Morton
2012-07-13 5:34 ` Artem Bityutskiy
2012-07-13 5:45 ` Andrew Morton
2012-07-13 5:47 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342099688-14894-2-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).