From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: [PATCH 1/3] fs/ufs: remove extra superblock write on unmount Date: Thu, 12 Jul 2012 16:28:06 +0300 Message-ID: <1342099688-14894-2-git-send-email-dedekind1@gmail.com> References: <1342099688-14894-1-git-send-email-dedekind1@gmail.com> Cc: Linux FS Maling List , Linux Kernel Maling List To: Andrew Morton , Al Viro , Evgeniy Dushistov Return-path: In-Reply-To: <1342099688-14894-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Artem Bityutskiy UFS calls 'ufs_write_super()' from 'ufs_put_super()' in order to write the superblocks to the media. However, it is not needed because VFS calls '->sync_fs()' before calling '->put_super()' - so by the time we are in 'ufs_write_super()', the superblocks are already synchronized. Signed-off-by: Artem Bityutskiy --- fs/ufs/super.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 302f340..ae91e0a 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c @@ -1238,9 +1238,6 @@ static void ufs_put_super(struct super_block *sb) UFSD("ENTER\n"); - if (sb->s_dirt) - ufs_write_super(sb); - if (!(sb->s_flags & MS_RDONLY)) ufs_put_super_internal(sb); -- 1.7.7.6