From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Czerner Subject: [PATCH 03/12 v2] shmem: pass LLONG_MAX to shmem_truncate_range Date: Fri, 13 Jul 2012 15:19:06 +0200 Message-ID: <1342185555-21146-3-git-send-email-lczerner@redhat.com> References: <1342185555-21146-1-git-send-email-lczerner@redhat.com> Cc: linux-fsdevel@vger.kernel.org, tytso@mit.edu, achender@linux.vnet.ibm.com, Lukas Czerner , Hugh Dickins To: linux-ext4@vger.kernel.org Return-path: In-Reply-To: <1342185555-21146-1-git-send-email-lczerner@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Currently we're passing -1 to shmem_truncate_range which can then call truncate_inode_pages_range() which is actually really confusing since the argument is signed so we do not get "huge" number as one would expect, but rather just -1. To make things clearer and easier for truncate_inode_pages_range() just pass LLONG_MAX since it is actually what was intended anyway. It also makes thing easier for allowing truncate_inode_pages_range() to handle non page aligned regions. Moreover letting the lend argument to be negative might actually hide some bugs. Signed-off-by: Lukas Czerner Cc: Hugh Dickins --- mm/shmem.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 4ce02e0..3199733 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2961,7 +2961,8 @@ void shmem_unlock_mapping(struct address_space *mapping) void shmem_truncate_range(struct inode *inode, loff_t lstart, loff_t lend) { - truncate_inode_pages_range(inode->i_mapping, lstart, lend); + truncate_inode_pages_range(inode->i_mapping, lstart, + lend == -1 ? LLONG_MAX : last); } EXPORT_SYMBOL_GPL(shmem_truncate_range); -- 1.7.7.6