From: "Thomas Schmitt" <scdbackup@gmx.net>
To: linux-fsdevel@vger.kernel.org
Cc: jack@suse.cz,matthias.goergens@gmail.com
Subject: Re: [PATCH] isofs: Fix handling of directories with tight blocks
Date: Tue, 22 Sep 2026 16:59:16 +0200 [thread overview]
Message-ID: <13424504872184120250@scdbackup.webframe.org> (raw)
In-Reply-To: <20260922121912.2258134-2-jack@suse.cz>
Hi,
nitpicking about a comment in isofs_find_entry():
> + * If we are at the end of the block or at its zero-padded
> + * length, move to the next block.
s/length/tail/
As unprepared reader i would wonder what "zero-padded length" is.
The comment in do_isofs_readdir() says "zero-padded tail", which i
deem more understandable.
As far as the program code is concerned:
Reviewed-by: Thomas Schmitt <scdbackup@gmx.net>
Have a nice day :)
Thomas
next prev parent reply other threads:[~2026-09-22 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 12:19 [PATCH] isofs: Fix handling of directories with tight blocks Jan Kara
2026-09-22 14:59 ` Thomas Schmitt [this message]
2026-09-23 10:22 ` Jan Kara
2026-09-23 15:31 ` [PATCH] isofs: Always advance to the next block in readdir and lookup Matthias Goergens
2026-09-23 16:55 ` Jan Kara
2026-09-23 17:52 ` Matthias Goergens
2026-09-23 18:40 ` Jan Kara
2026-09-25 4:28 ` Matthias Goergens
2026-09-25 2:34 ` [syzbot ci] Re: isofs: Fix handling of directories with tight blocks syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13424504872184120250@scdbackup.webframe.org \
--to=scdbackup@gmx.net \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox