Re: hfsplus journalling support revisited, netgear, and fsck.hfsplus's observation.

[Vyacheslav Dubeyko <slava@dubeyko.com>]

Hi Hin-Tak,

Sorry, I can see from the hfsplus code about what you are talking. You
are right. The situation is clear for me. It needs to work. :-)

Thank you for bug report.

With the best regards,
Vyacheslav Dubeyko.

On Mon, 2012-07-23 at 23:35 +0400, Vyacheslav Dubeyko wrote:
> Hi,
> 
> On Jul 22, 2012, at 1:06 AM, Hin-Tak Leung wrote:
> 
> > 
> > Correct - two interesting bugs. I thought I had supplied enough details for others to try to reproduce? The first is simply about deleting files, the latter about deleting files with extended attributes. So, to reproduce:
> > 
> > 1. Have a hfs+ volume (created under Mac OS X would be better). Make sure it passed fsck.hfsplus (on linux).
> > 2. copy the system Fonts folder (I think it is under /Library/Fonts) to it from Mac OS X. Font files have extended attributes, but other system files might do too.
> > 3. Try to delete some of those files from Linux.
> > 4. umount, run fsck.hfsplus on the volume. One would see:
> > 
> >   Executing fsck_hfs (version 540.1-Linux).
> >   ...
> > ** Checking extents overflow file.
> >   Unused node is not erased (node = 1)
> > ** Checking catalog file.
> >   Unused node is not erased (node = 18)
> >   ...
> > ** Checking extended attributes file.
> >   Incorrect number of extended attributes
> >   (It should be 13 instead of 6)
> >   ...
> > ** Repairing volume.
> > 	RepairAttributesCheckABT: No matching catalog record found for id=438
> >   ...
> > ** Rechecking volume.
> >   ...
> > ** The volume journalled was repaired successfully.
> 
> Currently, I can't reproduce these bugs. I think that I have not fully correct reproduction path. So, I have some questions.
> What version of Linux kernel do you use? Or maybe do you have hfsplus file system driver code from special branch?
> 
> I tried to reproduce these bugs on non-journaled hfs+ volume, firstly, but without success. As I can see you use journaled hfs+ volume. Maybe the forced mount of journaled hfs+ was the reason of these bugs? By the way do you use MBR or GPT partitioned disk?
> 
> > 
> > 'Unused node is not erased' & 'Incorrect number of extended attributes' were essentially what I wrote earlier. BTW, I ran fsck.hfsplus with:
> > 
> > fsck.hfsplus -d -D 0x0033 -f 
> > 
> > - i.e. maximum amount of information, and have a look even if it appears to be clean. (there are -l, -y and -n switches to control whether fsck.hfsplus would actually fix anything found or leave it alone and just output info).
> > 
> > The font folder is only about a few hundred MB, so one should be able to experiment with a small pen drive and do byte-level comparisons to see what fsk.hfsplus is not happy about and what does it change - although I am sure looking at diskdev_cmds's source would also be useful. I just happen to want the font folder for other things I do.
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> With the best regards,
> Vyacheslav Dubeyko.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html